[Impala-CR](cdh5-trunk) IMPALA-1939: Impalad should not require a co-located DataNode

["Juan Yu (Code Review)" <ge...@cloudera.org>]

Juan Yu has posted comments on this change.

Change subject: IMPALA-1939: Impalad should not require a co-located DataNode
......................................................................


Patch Set 5:

(2 comments)

Could you also rebase?

http://gerrit.cloudera.org:8080/#/c/1121/5/fe/src/main/java/com/cloudera/impala/service/JniFrontend.java
File fe/src/main/java/com/cloudera/impala/service/JniFrontend.java:

Line 683:       if (!((fs instanceof DistributedFileSystem) || (fs instanceof S3AFileSystem) ||
Do we currently support all s3 filesystem, or just s3a?
We also support LocalFilesystem now, right?


Line 684:         (fs instanceof NativeS3FileSystem) || (fs instanceof S3FileSystem))) {
wrong indentation here and below.


-- 
To view, visit http://gerrit.cloudera.org:8080/1121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Anuj Phadke <ap...@cloudera.com>
Gerrit-Reviewer: Anuj Phadke <ap...@cloudera.com>
Gerrit-Reviewer: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes