[GitHub] ctubbsii commented on issue #1005: FLUO-991 Format Source

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #1005: FLUO-991 Format Source
URL: https://github.com/apache/fluo/pull/1005#issuecomment-358715786
 
 
   I can review it now. It looks okay to me. It kind of raises the question, though: how much scrutiny needs to be reviewed before committing automatic formatting changes performed by our preexisting build tooling? I think probably very little, since the build tools and their configuration have already been reviewed and agreed upon.
   
   I like that the PR was opened, even though it was merged in without an explicit review. That gives extra opportunity to review, but technically, this should have waited until a review. It also could have waited until the next substantive code change, too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services