You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/11/22 11:33:57 UTC

Review Request 69425: Fixed name of task created when running mesos-cli-tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69425/
-----------------------------------------------------------

Review request for mesos and Kevin Klues.


Bugs: MESOS-9399
    https://issues.apache.org/jira/browse/MESOS-9399


Repository: mesos


Description
-------

Fixed name of task created when running mesos-cli-tests.


Diffs
-----

  src/python/cli_new/lib/cli/tests/base.py c28e2a65b5c1b881c2f4eb09baf9806338f26e40 


Diff: https://reviews.apache.org/r/69425/diff/1/


Testing
-------

```
(mesos-cli) ?  cli_new (MESOS-9399) ? mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok

----------------------------------------------------------------------
Ran 7 tests in 19.732s

OK
```


Thanks,

Armand Grillet


Re: Review Request 69425: Fixed name of task created when running mesos-cli-tests.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69425/#review210810
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Nov. 22, 2018, 11:33 vorm., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69425/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2018, 11:33 vorm.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9399
>     https://issues.apache.org/jira/browse/MESOS-9399
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed name of task created when running mesos-cli-tests.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/lib/cli/tests/base.py c28e2a65b5c1b881c2f4eb09baf9806338f26e40 
> 
> 
> Diff: https://reviews.apache.org/r/69425/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> (mesos-cli) ?  cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> 
> ----------------------------------------------------------------------
> Ran 7 tests in 19.732s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Re: Review Request 69425: Fixed name of task created when running mesos-cli-tests.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69425/#review210862
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Nov. 22, 2018, 11:33 vorm., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69425/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2018, 11:33 vorm.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9399
>     https://issues.apache.org/jira/browse/MESOS-9399
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed name of task created when running mesos-cli-tests.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/lib/cli/tests/base.py c28e2a65b5c1b881c2f4eb09baf9806338f26e40 
> 
> 
> Diff: https://reviews.apache.org/r/69425/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> (mesos-cli) ?  cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> 
> ----------------------------------------------------------------------
> Ran 7 tests in 19.732s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>