You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/20 03:05:03 UTC
[GitHub] [spark] HeartSaVioR commented on a change in pull request #30024: [SPARK-32229][SQL]Fix PostgresConnectionProvider and MSSQLConnectionProvider by accessing wrapped driver
HeartSaVioR commented on a change in pull request #30024:
URL: https://github.com/apache/spark/pull/30024#discussion_r508180571
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/DriverRegistry.scala
##########
@@ -58,5 +59,15 @@ object DriverRegistry extends Logging {
}
}
}
+
+ def get(className: String): Driver = {
Review comment:
I'm actually in favor of this change - DriverRegistry deals with wrapping on register, and this will also let DriverRegistry deal with unwrapping on get. JdbcUtils no longer needs to know about these details - it just needs to know that it should use `DriverRegistry` instead of `DriverManager`.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/DriverRegistry.scala
##########
@@ -58,5 +59,15 @@ object DriverRegistry extends Logging {
}
}
}
+
+ def get(className: String): Driver = {
Review comment:
I'm actually in favor of this change - `DriverRegistry` deals with wrapping on register, and this will also let `DriverRegistry` deal with unwrapping on get. `JdbcUtils` no longer needs to know about these details - it just needs to know that it should use `DriverRegistry` instead of `DriverManager`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org