[GitHub] [superset] dpgaspar commented on a change in pull request #18064: feat: datasource access to allow more granular access to tables on SQL Lab

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #18064:
URL: https://github.com/apache/superset/pull/18064#discussion_r802701918



##########
File path: superset/databases/filters.py
##########
@@ -25,21 +25,28 @@
 
 class DatabaseFilter(BaseFilter):
     # TODO(bogdan): consider caching.
-    def schema_access_databases(self) -> Set[str]:  # noqa pylint: disable=no-self-use
+
+    def can_access_databases(  # noqa pylint: disable=no-self-use

Review comment:
       nit: any reason why this can't be `@staticmethod` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org