You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2020/11/16 15:31:15 UTC
[GitHub] [maven-archiver] elharo opened a new pull request #13: test was asserting more than Java promises
elharo opened a new pull request #13:
URL: https://github.com/apache/maven-archiver/pull/13
Consequently failing flakily. Last modified time is platform dependent and not a simpler property of an object
@michael-o
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-archiver] rfscholte commented on pull request #13: test was asserting more than Java promises
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #13:
URL: https://github.com/apache/maven-archiver/pull/13#issuecomment-728265093
ok, just wanted to make sure change is done for the right reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-archiver] rfscholte commented on pull request #13: test was asserting more than Java promises
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #13:
URL: https://github.com/apache/maven-archiver/pull/13#issuecomment-728251174
Wait a minute, isn't this fixed with https://github.com/codehaus-plexus/plexus-archiver/commit/e55f320f190bc5fe2b1029c4fd8bb3e294a299bc ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-archiver] elharo commented on pull request #13: test was asserting more than Java promises
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #13:
URL: https://github.com/apache/maven-archiver/pull/13#issuecomment-728255605
I don't think it is. That was an incorrect diagnosis of the test failure. The modification data equality failures were not simply the result of truncating milliseconds; and if they had been, would have been fixed by JDK 10+, which they weren't.
The real issue is that modification dates aren't always precisely reproducible to the millisecond and can change asynchornously. It looks like a simple setter/getter for an object property, but it isn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-archiver] elharo merged pull request #13: test was asserting more than Java promises
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #13:
URL: https://github.com/apache/maven-archiver/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org