You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/25 02:49:12 UTC
[GitHub] [incubator-dolphinscheduler] gaojun2048 opened a new pull request
#1563: Added the maven profile to build rpm packages
gaojun2048 opened a new pull request #1563: Added the maven profile to build rpm packages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1563
## What is the purpose of the pull request
**Hello , This pull request adds rpmbuild plugin**
**The associated issue is Develops an Ambari plugin about DS : https://github.com/apache/incubator-dolphinscheduler/issues/1469**
## Brief change log
*add rpmbuild plugin*
- *Add maven-dependency-plugin and rpm-maven-plugion in root pom.xml*
- *Add profile rpmbuild in dolphinscheduler-dist/pom.xml*
- *Removed some duplicate operations in dolphinscheduler-dist/src/main/assembly/dolphinscheduler-binary.xml *
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] gaojun2048 commented on a change in
pull request #1563: Added the maven profile to build rpm packages
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on a change in pull request #1563: Added the maven profile to build rpm packages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1563#discussion_r361397527
##########
File path: dolphinscheduler-dist/pom.xml
##########
@@ -101,6 +101,276 @@
</plugins>
</build>
</profile>
+
+ <profile>
+ <id>rpmbuild</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <configuration>
+ <outputDirectory>${project.build.directory}/lib</outputDirectory>
+ <overWriteReleases>false</overWriteReleases>
+ <overWriteSnapshots>false</overWriteSnapshots>
+ <overWriteIfNewer>true</overWriteIfNewer>
+ <excludeScope>provided</excludeScope>
+ </configuration>
+ <executions>
+ <execution>
+ <id>copy-dependencies</id>
+ <phase>package</phase>
+ <goals>
+ <goal>copy-dependencies</goal>
+ </goals>
+
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>rpm-maven-plugin</artifactId>
+ <extensions>true</extensions>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>attached-rpm</goal>
+ </goals>
+ </execution>
+ </executions>
+
+ <configuration>
+ <name>apache-dolphinscheduler-incubating</name>
+ <release>1</release>
+ <distribution>apache dolphinscheduler incubating rpm</distribution>
+ <group>apache</group>
+ <packager>dolphinscheduler</packager>
+ <!-- <version>${project.version}</version> -->
+ <prefix>/opt/soft</prefix>
+
+ <defineStatements>
+ <!-- disable compile python when rpm build -->
+ <defineStatement>__os_install_post %(echo '%{__os_install_post}' | sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g')</defineStatement>
+ </defineStatements>
+ <mappings>
+ <mapping>
+ <directory>/opt/soft/${project.build.finalName}/conf</directory>
+ <filemode>755</filemode>
+ <username>root</username>
Review comment:
Yes, It`s ok .
I tested build with username argo , build success
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1563:
Added the maven profile to build rpm packages
Posted by GitBox <gi...@apache.org>.
lgcareer merged pull request #1563: Added the maven profile to build rpm packages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1563
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1563: Added the maven profile to build rpm packages
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1563: Added the maven profile to build rpm packages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1563#issuecomment-568827020
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=h1) Report
> Merging [#1563](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4bbf31f8076f0ba0c8722ea98738ee1c50f2b6ff?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1563 +/- ##
========================================
- Coverage 7.63% 7.58% -0.05%
========================================
Files 278 277 -1
Lines 13750 13743 -7
Branches 2195 2194 -1
========================================
- Hits 1050 1043 -7
- Misses 12630 12631 +1
+ Partials 70 69 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/dolphinscheduler/common/utils/Preconditions.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1ByZWNvbmRpdGlvbnMuamF2YQ==) | `0% <0%> (-1.76%)` | :arrow_down: |
| [...dolphinscheduler/common/queue/TaskQueueZkImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3F1ZXVlL1Rhc2tRdWV1ZVprSW1wbC5qYXZh) | `71.66% <0%> (-0.16%)` | :arrow_down: |
| [...he/dolphinscheduler/common/zk/ZookeeperConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL1pvb2tlZXBlckNvbmZpZy5qYXZh) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=footer). Last update [4bbf31f...da60030](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] gaojun2048 commented on a change in
pull request #1563: Added the maven profile to build rpm packages
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on a change in pull request #1563: Added the maven profile to build rpm packages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1563#discussion_r361397581
##########
File path: dolphinscheduler-dist/pom.xml
##########
@@ -101,6 +101,276 @@
</plugins>
</build>
</profile>
+
+ <profile>
+ <id>rpmbuild</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <configuration>
+ <outputDirectory>${project.build.directory}/lib</outputDirectory>
+ <overWriteReleases>false</overWriteReleases>
+ <overWriteSnapshots>false</overWriteSnapshots>
+ <overWriteIfNewer>true</overWriteIfNewer>
+ <excludeScope>provided</excludeScope>
+ </configuration>
+ <executions>
+ <execution>
+ <id>copy-dependencies</id>
+ <phase>package</phase>
+ <goals>
+ <goal>copy-dependencies</goal>
+ </goals>
+
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>rpm-maven-plugin</artifactId>
+ <extensions>true</extensions>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>attached-rpm</goal>
+ </goals>
+ </execution>
+ </executions>
+
+ <configuration>
+ <name>apache-dolphinscheduler-incubating</name>
+ <release>1</release>
+ <distribution>apache dolphinscheduler incubating rpm</distribution>
+ <group>apache</group>
+ <packager>dolphinscheduler</packager>
+ <!-- <version>${project.version}</version> -->
+ <prefix>/opt/soft</prefix>
+
+ <defineStatements>
+ <!-- disable compile python when rpm build -->
+ <defineStatement>__os_install_post %(echo '%{__os_install_post}' | sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g')</defineStatement>
+ </defineStatements>
+ <mappings>
+ <mapping>
+ <directory>/opt/soft/${project.build.finalName}/conf</directory>
+ <filemode>755</filemode>
+ <username>root</username>
Review comment:
> I see the user and group is root default,if other user run `mvn clean package -P rpmbuild`,is it ok?
Yes, It`s ok .
I tested build with username argo , build success
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] gaojun2048 commented on a change in
pull request #1563: Added the maven profile to build rpm packages
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on a change in pull request #1563: Added the maven profile to build rpm packages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1563#discussion_r361397527
##########
File path: dolphinscheduler-dist/pom.xml
##########
@@ -101,6 +101,276 @@
</plugins>
</build>
</profile>
+
+ <profile>
+ <id>rpmbuild</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <configuration>
+ <outputDirectory>${project.build.directory}/lib</outputDirectory>
+ <overWriteReleases>false</overWriteReleases>
+ <overWriteSnapshots>false</overWriteSnapshots>
+ <overWriteIfNewer>true</overWriteIfNewer>
+ <excludeScope>provided</excludeScope>
+ </configuration>
+ <executions>
+ <execution>
+ <id>copy-dependencies</id>
+ <phase>package</phase>
+ <goals>
+ <goal>copy-dependencies</goal>
+ </goals>
+
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>rpm-maven-plugin</artifactId>
+ <extensions>true</extensions>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>attached-rpm</goal>
+ </goals>
+ </execution>
+ </executions>
+
+ <configuration>
+ <name>apache-dolphinscheduler-incubating</name>
+ <release>1</release>
+ <distribution>apache dolphinscheduler incubating rpm</distribution>
+ <group>apache</group>
+ <packager>dolphinscheduler</packager>
+ <!-- <version>${project.version}</version> -->
+ <prefix>/opt/soft</prefix>
+
+ <defineStatements>
+ <!-- disable compile python when rpm build -->
+ <defineStatement>__os_install_post %(echo '%{__os_install_post}' | sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g')</defineStatement>
+ </defineStatements>
+ <mappings>
+ <mapping>
+ <directory>/opt/soft/${project.build.finalName}/conf</directory>
+ <filemode>755</filemode>
+ <username>root</username>
Review comment:
Yes, It`s ok .
I tested build with username argo , build success
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1563:
Added the maven profile to build rpm packages
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #1563: Added the maven profile to build rpm packages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1563#issuecomment-569036326
please add how to use document on official website github : https://github.com/apache/incubator-dolphinscheduler-website
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] gaojun2048 commented on issue #1563:
Added the maven profile to build rpm packages
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on issue #1563: Added the maven profile to build rpm packages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1563#issuecomment-568852043
@dailidong I added auto create /opt/soft code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] gaojun2048 commented on issue #1563:
Added the maven profile to build rpm packages
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on issue #1563: Added the maven profile to build rpm packages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1563#issuecomment-568849503
> /opt/soft dir will auto create or not ?
>
> by the way, how to build rpm package？
1、The build command:
mvn -U clean package -Prpmbuild -Dmaven.test.skip=true
2、Sorry , I just add /opt/soft auto create code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1563:
Added the maven profile to build rpm packages
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1563: Added the maven profile to build rpm packages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1563#issuecomment-568827020
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`dev@4bbf31f`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1563 +/- ##
=====================================
Coverage ? 7.63%
=====================================
Files ? 278
Lines ? 13750
Branches ? 2195
=====================================
Hits ? 1050
Misses ? 12630
Partials ? 70
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=footer). Last update [4bbf31f...787d407](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] lgcareer commented on a change in pull
request #1563: Added the maven profile to build rpm packages
Posted by GitBox <gi...@apache.org>.
lgcareer commented on a change in pull request #1563: Added the maven profile to build rpm packages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1563#discussion_r361379713
##########
File path: dolphinscheduler-dist/pom.xml
##########
@@ -101,6 +101,276 @@
</plugins>
</build>
</profile>
+
+ <profile>
+ <id>rpmbuild</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <configuration>
+ <outputDirectory>${project.build.directory}/lib</outputDirectory>
+ <overWriteReleases>false</overWriteReleases>
+ <overWriteSnapshots>false</overWriteSnapshots>
+ <overWriteIfNewer>true</overWriteIfNewer>
+ <excludeScope>provided</excludeScope>
+ </configuration>
+ <executions>
+ <execution>
+ <id>copy-dependencies</id>
+ <phase>package</phase>
+ <goals>
+ <goal>copy-dependencies</goal>
+ </goals>
+
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>rpm-maven-plugin</artifactId>
+ <extensions>true</extensions>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>attached-rpm</goal>
+ </goals>
+ </execution>
+ </executions>
+
+ <configuration>
+ <name>apache-dolphinscheduler-incubating</name>
+ <release>1</release>
+ <distribution>apache dolphinscheduler incubating rpm</distribution>
+ <group>apache</group>
+ <packager>dolphinscheduler</packager>
+ <!-- <version>${project.version}</version> -->
+ <prefix>/opt/soft</prefix>
+
+ <defineStatements>
+ <!-- disable compile python when rpm build -->
+ <defineStatement>__os_install_post %(echo '%{__os_install_post}' | sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g')</defineStatement>
+ </defineStatements>
+ <mappings>
+ <mapping>
+ <directory>/opt/soft/${project.build.finalName}/conf</directory>
+ <filemode>755</filemode>
+ <username>root</username>
Review comment:
I see the user and group is root default,if other user run `mvn clean package -P rpmbuild`,is it ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services