You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2023/07/21 21:49:01 UTC

[superset] branch master updated: fix: update svgr webpack config to use svg dimensions (#24747)

This is an automated email from the ASF dual-hosted git repository.

elizabeth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new f856ba246e fix: update svgr webpack config to use svg dimensions (#24747)
f856ba246e is described below

commit f856ba246e39709aa35461a7007177d4608f6c1b
Author: Elizabeth Thompson <es...@gmail.com>
AuthorDate: Fri Jul 21 14:48:54 2023 -0700

    fix: update svgr webpack config to use svg dimensions (#24747)
---
 superset-frontend/webpack.config.js | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js
index a1516f25b0..f0bab49244 100644
--- a/superset-frontend/webpack.config.js
+++ b/superset-frontend/webpack.config.js
@@ -419,13 +419,11 @@ const config = {
           {
             loader: '@svgr/webpack',
             options: {
-              icon: true,
-              svgo: false,
-              svgoConfig: {
-                plugins: [{ removeViewBox: false }],
-              },
               titleProp: true,
               ref: true,
+              // this is the default value for the icon. Using other values
+              // here will replace width and height in svg with 1em
+              icon: false,
             },
           },
         ],