You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by Dave <sn...@gmail.com> on 2021/12/14 22:09:28 UTC
VOTE: Release Roller v6.1.0
I propose that we release Roller v6.1.0 based on the code that is currently
in the master branch. I have prepared a release candidate and some release
notes, below.
Please vote in the next 72 hours to approve this release.
+1 to release
-1 not to release (with reasons)
Thanks to Michael Bien for all his work since the 6.0.1 release on bug
fixes, general improvements and dependency updates like the important one
he made today to upgrade Log4j.
The release candidate files are here:
https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/
Release notes
This is a bug fix and dependency update release that includes all changes
made to the master branch since Dev 27, 2019. It also includes the new
patched Log4j release. This release should be a drop-in replacement of the
previous v6.0.1 release.
Here is a summary of the changes.
All Pull Requests that were merged since Dec 27, 2019
https://github.com/apache/roller/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged
Bug resolved since Dec 27, 2019
https://issues.apache.org/jira/issues/?jql=project%20%3D%20ROL%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20resolutiondate%20%3E%20%272019%2F12%2F27%27
And there is one database change: in the weblog table, the column blacklist
has been renamed to bannedwordslist.
Re: VOTE: Release Roller v6.1.0
Posted by Michael Bien <mb...@gmail.com>.
On 15.12.21 11:53, Greg Huber wrote:
>
> ####
>
> may be worth checking:
>
> From the docs:
>
> The quotes are wrong ie ` possibly make users check the script??:
>
> grant all on rollerdb.* to scott@`%' identified by `tiger';
>
> grant all on rollerdb.* to scott@localhost identified by `tiger';
i haven't touched the doc, maybe someone else can take a look
>
>
> roller-custom.properties
>
> Does not seem to work, defaults to tomcat home /logs:
>
> log4j.appender.roller.File=/usr/local/rollerdata/roller.log
>
>
here the old PR:
https://github.com/apache/roller/pull/68
"
changes:
- loggers can no longer be configured using roller.properties or
roller-custom.properties.
- configuration is now in log4j2.xml.
- a custom config file can be set using the standard
log4j.configurationFile system property.
(can be for example in roller-custom.properties or set as JVM -D
property)
"
default config can be used as template, see comments:
https://github.com/apache/roller/blob/master/app/src/main/resources/log4j2.xml
-michael
Re: VOTE: Release Roller v6.1.0
Posted by Michael Bien <mb...@gmail.com>.
On 15.12.21 11:53, Greg Huber wrote:
>
>
> ####
>
> When doing a search, and logged, we get a login url on the bottom of
> search page.
>
> http://localhost:8080/roller/mainpage/search?q=test
>
> * Front Page <http://localhost:8080/roller/>
> * Weblog <http://localhost:8080/roller/mainpage/>
> * Login <http://localhost:8080/roller/roller-ui/login-redirect.rol>
turns out that the SearchServlet didn't copy the user to the model. The
search results page always thinks the user is logged out. This bug was
likely there from the beginning.
https://github.com/apache/roller/pull/111
-michael
Re: VOTE: Release Roller v6.1.0
Posted by Greg Huber <gr...@gmail.com>.
Had to do a complete reinstall. Good work.
+1 b
Cheers Greg
####
may be worth checking:
From the docs:
The quotes are wrong ie ` possibly make users check the script??:
grant all on rollerdb.* to scott@`%' identified by `tiger';
grant all on rollerdb.* to scott@localhost identified by `tiger';
roller-custom.properties
Does not seem to work, defaults to tomcat home /logs:
log4j.appender.roller.File=/usr/local/rollerdata/roller.log
####
When doing a search, and logged, we get a login url on the bottom of
search page.
http://localhost:8080/roller/mainpage/search?q=test
* Front Page <http://localhost:8080/roller/>
* Weblog <http://localhost:8080/roller/mainpage/>
* Login <http://localhost:8080/roller/roller-ui/login-redirect.rol>
####
http://localhost:8080/roller/roller-ui/authoring/categories.rol?weblog=mainpage
When creating a category, if the url is invalid it does not create the
entry. Might be the correct behaviour? but there is no validation
warning on save, just goes back to the categories page.
####
On 14/12/2021 22:09, Dave wrote:
> I propose that we release Roller v6.1.0 based on the code that is currently
> in the master branch. I have prepared a release candidate and some release
> notes, below.
>
> Please vote in the next 72 hours to approve this release.
> +1 to release
> -1 not to release (with reasons)
>
> Thanks to Michael Bien for all his work since the 6.0.1 release on bug
> fixes, general improvements and dependency updates like the important one
> he made today to upgrade Log4j.
>
> The release candidate files are here:
> https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/
>
> Release notes
>
> This is a bug fix and dependency update release that includes all changes
> made to the master branch since Dev 27, 2019. It also includes the new
> patched Log4j release. This release should be a drop-in replacement of the
> previous v6.0.1 release.
>
> Here is a summary of the changes.
>
> All Pull Requests that were merged since Dec 27, 2019
> https://github.com/apache/roller/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged
>
> Bug resolved since Dec 27, 2019
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ROL%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20resolutiondate%20%3E%20%272019%2F12%2F27%27
>
> And there is one database change: in the weblog table, the column blacklist
> has been renamed to bannedwordslist.
>
VOTE CANCELLED: Release Roller v6.1.0
Posted by Dave <sn...@gmail.com>.
Thanks everybody for your quick action in voting, but we need to spin a new
release candidate.
Dave
On Sat, Dec 18, 2021 at 1:06 AM Michael Bien <mb...@gmail.com> wrote:
> log4j2 2.17 is (almost) released.
>
>
> https://mail-archives.apache.org/mod_mbox/logging-dev/202112.mbox/%3C66E7128B-B0FC-47AF-ABB3-BB360B40FAB6%40dslextreme.com%3E
>
> should we bump the dependencies again, add the CommentServlet PR and
> spin another rc?
>
> -michael
>
>
> On 14.12.21 23:09, Dave wrote:
> > I propose that we release Roller v6.1.0 based on the code that is
> currently
> > in the master branch. I have prepared a release candidate and some
> release
> > notes, below.
> >
> > Please vote in the next 72 hours to approve this release.
> > +1 to release
> > -1 not to release (with reasons)
> >
> > Thanks to Michael Bien for all his work since the 6.0.1 release on bug
> > fixes, general improvements and dependency updates like the important one
> > he made today to upgrade Log4j.
> >
> > The release candidate files are here:
> > https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/
> >
> > Release notes
> >
> > This is a bug fix and dependency update release that includes all changes
> > made to the master branch since Dev 27, 2019. It also includes the new
> > patched Log4j release. This release should be a drop-in replacement of
> the
> > previous v6.0.1 release.
> >
> > Here is a summary of the changes.
> >
> > All Pull Requests that were merged since Dec 27, 2019
> > https://github.com/apache/roller/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged
> >
> > Bug resolved since Dec 27, 2019
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ROL%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20resolutiondate%20%3E%20%272019%2F12%2F27%27
> >
> > And there is one database change: in the weblog table, the column
> blacklist
> > has been renamed to bannedwordslist.
> >
>
>
Re: VOTE: Release Roller v6.1.0
Posted by Michael Bien <mb...@gmail.com>.
log4j2 2.17 is (almost) released.
https://mail-archives.apache.org/mod_mbox/logging-dev/202112.mbox/%3C66E7128B-B0FC-47AF-ABB3-BB360B40FAB6%40dslextreme.com%3E
should we bump the dependencies again, add the CommentServlet PR and
spin another rc?
-michael
On 14.12.21 23:09, Dave wrote:
> I propose that we release Roller v6.1.0 based on the code that is currently
> in the master branch. I have prepared a release candidate and some release
> notes, below.
>
> Please vote in the next 72 hours to approve this release.
> +1 to release
> -1 not to release (with reasons)
>
> Thanks to Michael Bien for all his work since the 6.0.1 release on bug
> fixes, general improvements and dependency updates like the important one
> he made today to upgrade Log4j.
>
> The release candidate files are here:
> https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/
>
> Release notes
>
> This is a bug fix and dependency update release that includes all changes
> made to the master branch since Dev 27, 2019. It also includes the new
> patched Log4j release. This release should be a drop-in replacement of the
> previous v6.0.1 release.
>
> Here is a summary of the changes.
>
> All Pull Requests that were merged since Dec 27, 2019
> https://github.com/apache/roller/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged
>
> Bug resolved since Dec 27, 2019
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ROL%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20resolutiondate%20%3E%20%272019%2F12%2F27%27
>
> And there is one database change: in the weblog table, the column blacklist
> has been renamed to bannedwordslist.
>
Re: VOTE: Release Roller v6.1.0
Posted by Kohei Nozaki <ko...@nozaki.me>.
+1
> On Dec 15, 2021, at 9:37, Michael Bien <mb...@gmail.com> wrote:
>
> +1 (binding)
>
> ran some manual tests:
>
> - verified sha256 for the binaries
> - verified that log4j2 2.16 is used, and nothing else
> - tested fresh deployment on tomcat 9 + postgres 14.1 + JDK 11 + debian-slim-bullseye in a podman container
> - repeated same test on JDK 17
> - didn't test the migration logic with the release build, but I did that back when it was implemented in master on my own blog (hsqldb, jetty, jdk17)
>
> best regards,
> michael
>
>> On 14.12.21 23:09, Dave wrote:
>> I propose that we release Roller v6.1.0 based on the code that is currently
>> in the master branch. I have prepared a release candidate and some release
>> notes, below.
>>
>> Please vote in the next 72 hours to approve this release.
>> +1 to release
>> -1 not to release (with reasons)
>>
>> Thanks to Michael Bien for all his work since the 6.0.1 release on bug
>> fixes, general improvements and dependency updates like the important one
>> he made today to upgrade Log4j.
>>
>> The release candidate files are here:
>> https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/
>>
>> Release notes
>>
>> This is a bug fix and dependency update release that includes all changes
>> made to the master branch since Dev 27, 2019. It also includes the new
>> patched Log4j release. This release should be a drop-in replacement of the
>> previous v6.0.1 release.
>>
>> Here is a summary of the changes.
>>
>> All Pull Requests that were merged since Dec 27, 2019
>> https://github.com/apache/roller/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged
>>
>> Bug resolved since Dec 27, 2019
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ROL%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20resolutiondate%20%3E%20%272019%2F12%2F27%27
>>
>> And there is one database change: in the weblog table, the column blacklist
>> has been renamed to bannedwordslist.
>>
>
Re: VOTE: Release Roller v6.1.0
Posted by Michael Bien <mb...@gmail.com>.
+1 (binding)
ran some manual tests:
- verified sha256 for the binaries
- verified that log4j2 2.16 is used, and nothing else
- tested fresh deployment on tomcat 9 + postgres 14.1 + JDK 11 +
debian-slim-bullseye in a podman container
- repeated same test on JDK 17
- didn't test the migration logic with the release build, but I did that
back when it was implemented in master on my own blog (hsqldb, jetty, jdk17)
best regards,
michael
On 14.12.21 23:09, Dave wrote:
> I propose that we release Roller v6.1.0 based on the code that is currently
> in the master branch. I have prepared a release candidate and some release
> notes, below.
>
> Please vote in the next 72 hours to approve this release.
> +1 to release
> -1 not to release (with reasons)
>
> Thanks to Michael Bien for all his work since the 6.0.1 release on bug
> fixes, general improvements and dependency updates like the important one
> he made today to upgrade Log4j.
>
> The release candidate files are here:
> https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/
>
> Release notes
>
> This is a bug fix and dependency update release that includes all changes
> made to the master branch since Dev 27, 2019. It also includes the new
> patched Log4j release. This release should be a drop-in replacement of the
> previous v6.0.1 release.
>
> Here is a summary of the changes.
>
> All Pull Requests that were merged since Dec 27, 2019
> https://github.com/apache/roller/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged
>
> Bug resolved since Dec 27, 2019
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ROL%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20resolutiondate%20%3E%20%272019%2F12%2F27%27
>
> And there is one database change: in the weblog table, the column blacklist
> has been renamed to bannedwordslist.
>