You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Jiuming Tao <jm...@streamnative.io.INVALID> on 2022/11/17 09:06:50 UTC
[VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics
Dear Pulsar Community,
Please review and vote on this PIP.
PIP link: https://github.com/apache/pulsar/issues/18319 <https://github.com/apache/pulsar/issues/18319>
Discuss thread: https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6 <https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6>
Thanks,
Tao Jiuming
Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics
Posted by PengHui Li <pe...@apache.org>.
+1
Penghui
On Fri, Nov 18, 2022 at 12:51 AM Jiuming Tao <jm...@streamnative.io.invalid>
wrote:
> My understanding is that the PIP will add a generic mechanism to track
> commands ("pulsar_broker_command_execution_latency" with label
> "code”)
>
>
> pulsar_broker_command_execution_latency with `command` label to track the
> command execution latency
> pulsar_broker_command_execution_failed with `command` and `code` labels to
> track the command execution failed
>
> but we will implement it only for
> CommandPartitionedTopicMetadata
>
>
>
> Yes, for this PIP we only implement these two metrics for
> CommandPartitionedTopicMetadata, but we will implement them for all the
> commands in the future
>
> Thanks,
> Tao Jiuming
>
> Enrico Olivelli <eo...@gmail.com> 于2022年11月17日周四 18:03写道：
>
> > +1 (binding)
> >
> > My understanding is that the PIP will add a generic mechanism to track
> > commands ("pulsar_broker_command_execution_latency" with label
> > "code") but we will implement it only for
> > CommandPartitionedTopicMetadata
> > Enrico
> >
> > Il giorno gio 17 nov 2022 alle ore 10:36 Jiuming Tao
> > <jm...@streamnative.io.invalid> ha scritto:
> > >
> > > Hi Enrico,
> > >
> > > Tracking all the cmds will lead to a lot of changes, BrokerInterceptors
> > only triggered when the cmd entering.
> > >
> > > This PIP only tracks CommandPartitionedTopicMetadata cmd, but I’ll find
> > a way to track all the cmds, and I’ll
> > > create another PIP the do it.
> > >
> > >
> > > Thanks,
> > > Tao Jiuming
> > >
> > > > 2022年11月17日 下午5:27，Enrico Olivelli <eo...@gmail.com> 写道：
> > > >
> > > > Tao,
> > > > before voting on this proposal, I think that we should change the
> > title.
> > > > Now the PIP refers to tracking all the commands and not only
> > > > CommandPartitionedTopicMetadata, is this correct?
> > > >
> > > > Enrico
> > > >
> > > > Il giorno gio 17 nov 2022 alle ore 10:07 Jiuming Tao
> > > > <jm...@streamnative.io.invalid> ha scritto:
> > > >>
> > > >> Dear Pulsar Community,
> > > >>
> > > >> Please review and vote on this PIP.
> > > >>
> > > >> PIP link: https://github.com/apache/pulsar/issues/18319 <
> > https://github.com/apache/pulsar/issues/18319>
> > > >>
> > > >> Discuss thread:
> > https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6 <
> > https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6>
> > > >>
> > > >> Thanks,
> > > >> Tao Jiuming
> > >
> >
>
Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics
Posted by Jiuming Tao <jm...@streamnative.io.INVALID>.
My understanding is that the PIP will add a generic mechanism to track
commands ("pulsar_broker_command_execution_latency" with label
"code”)
pulsar_broker_command_execution_latency with `command` label to track the
command execution latency
pulsar_broker_command_execution_failed with `command` and `code` labels to
track the command execution failed
but we will implement it only for
CommandPartitionedTopicMetadata
Yes, for this PIP we only implement these two metrics for
CommandPartitionedTopicMetadata, but we will implement them for all the
commands in the future
Thanks,
Tao Jiuming
Enrico Olivelli <eo...@gmail.com> 于2022年11月17日周四 18:03写道：
> +1 (binding)
>
> My understanding is that the PIP will add a generic mechanism to track
> commands ("pulsar_broker_command_execution_latency" with label
> "code") but we will implement it only for
> CommandPartitionedTopicMetadata
> Enrico
>
> Il giorno gio 17 nov 2022 alle ore 10:36 Jiuming Tao
> <jm...@streamnative.io.invalid> ha scritto:
> >
> > Hi Enrico,
> >
> > Tracking all the cmds will lead to a lot of changes, BrokerInterceptors
> only triggered when the cmd entering.
> >
> > This PIP only tracks CommandPartitionedTopicMetadata cmd, but I’ll find
> a way to track all the cmds, and I’ll
> > create another PIP the do it.
> >
> >
> > Thanks,
> > Tao Jiuming
> >
> > > 2022年11月17日 下午5:27，Enrico Olivelli <eo...@gmail.com> 写道：
> > >
> > > Tao,
> > > before voting on this proposal, I think that we should change the
> title.
> > > Now the PIP refers to tracking all the commands and not only
> > > CommandPartitionedTopicMetadata, is this correct?
> > >
> > > Enrico
> > >
> > > Il giorno gio 17 nov 2022 alle ore 10:07 Jiuming Tao
> > > <jm...@streamnative.io.invalid> ha scritto:
> > >>
> > >> Dear Pulsar Community,
> > >>
> > >> Please review and vote on this PIP.
> > >>
> > >> PIP link: https://github.com/apache/pulsar/issues/18319 <
> https://github.com/apache/pulsar/issues/18319>
> > >>
> > >> Discuss thread:
> https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6 <
> https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6>
> > >>
> > >> Thanks,
> > >> Tao Jiuming
> >
>
Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics
Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (binding)
My understanding is that the PIP will add a generic mechanism to track
commands ("pulsar_broker_command_execution_latency" with label
"code") but we will implement it only for
CommandPartitionedTopicMetadata
Enrico
Il giorno gio 17 nov 2022 alle ore 10:36 Jiuming Tao
<jm...@streamnative.io.invalid> ha scritto:
>
> Hi Enrico,
>
> Tracking all the cmds will lead to a lot of changes, BrokerInterceptors only triggered when the cmd entering.
>
> This PIP only tracks CommandPartitionedTopicMetadata cmd, but I’ll find a way to track all the cmds, and I’ll
> create another PIP the do it.
>
>
> Thanks,
> Tao Jiuming
>
> > 2022年11月17日 下午5:27，Enrico Olivelli <eo...@gmail.com> 写道：
> >
> > Tao,
> > before voting on this proposal, I think that we should change the title.
> > Now the PIP refers to tracking all the commands and not only
> > CommandPartitionedTopicMetadata, is this correct?
> >
> > Enrico
> >
> > Il giorno gio 17 nov 2022 alle ore 10:07 Jiuming Tao
> > <jm...@streamnative.io.invalid> ha scritto:
> >>
> >> Dear Pulsar Community,
> >>
> >> Please review and vote on this PIP.
> >>
> >> PIP link: https://github.com/apache/pulsar/issues/18319 <https://github.com/apache/pulsar/issues/18319>
> >>
> >> Discuss thread: https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6 <https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6>
> >>
> >> Thanks,
> >> Tao Jiuming
>
Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics
Posted by Jiuming Tao <jm...@streamnative.io.INVALID>.
Hi Enrico,
Tracking all the cmds will lead to a lot of changes, BrokerInterceptors only triggered when the cmd entering.
This PIP only tracks CommandPartitionedTopicMetadata cmd, but I’ll find a way to track all the cmds, and I’ll
create another PIP the do it.
Thanks,
Tao Jiuming
> 2022年11月17日 下午5:27，Enrico Olivelli <eo...@gmail.com> 写道：
>
> Tao,
> before voting on this proposal, I think that we should change the title.
> Now the PIP refers to tracking all the commands and not only
> CommandPartitionedTopicMetadata, is this correct?
>
> Enrico
>
> Il giorno gio 17 nov 2022 alle ore 10:07 Jiuming Tao
> <jm...@streamnative.io.invalid> ha scritto:
>>
>> Dear Pulsar Community,
>>
>> Please review and vote on this PIP.
>>
>> PIP link: https://github.com/apache/pulsar/issues/18319 <https://github.com/apache/pulsar/issues/18319>
>>
>> Discuss thread: https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6 <https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6>
>>
>> Thanks,
>> Tao Jiuming
Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics
Posted by Enrico Olivelli <eo...@gmail.com>.
Tao,
before voting on this proposal, I think that we should change the title.
Now the PIP refers to tracking all the commands and not only
CommandPartitionedTopicMetadata, is this correct?
Enrico
Il giorno gio 17 nov 2022 alle ore 10:07 Jiuming Tao
<jm...@streamnative.io.invalid> ha scritto:
>
> Dear Pulsar Community,
>
> Please review and vote on this PIP.
>
> PIP link: https://github.com/apache/pulsar/issues/18319 <https://github.com/apache/pulsar/issues/18319>
>
> Discuss thread: https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6 <https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6>
>
> Thanks,
> Tao Jiuming
Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics
Posted by Haiting Jiang <ji...@gmail.com>.
+1 binding
Thanks,
Haiting
On Thu, Nov 24, 2022 at 1:05 AM Jiuming Tao
<jm...@streamnative.io.invalid> wrote:
>
>
> Bump
>
>
> > 2022年11月22日 下午4:03，Ran Gao <rg...@apache.org> 写道：
> >
> > +1 (unbinding)
> >
> > Thanks,
> > Ran
> >
> > On 2022/11/17 09:06:50 Jiuming Tao wrote:
> >> Dear Pulsar Community,
> >>
> >> Please review and vote on this PIP.
> >>
> >> PIP link: https://github.com/apache/pulsar/issues/18319 <https://github.com/apache/pulsar/issues/18319>
> >>
> >> Discuss thread: https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6 <https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6>
> >>
> >> Thanks,
> >> Tao Jiuming
>
Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics
Posted by Jiuming Tao <jm...@streamnative.io.INVALID>.
Bump
> 2022年11月22日 下午4:03，Ran Gao <rg...@apache.org> 写道：
>
> +1 (unbinding)
>
> Thanks,
> Ran
>
> On 2022/11/17 09:06:50 Jiuming Tao wrote:
>> Dear Pulsar Community,
>>
>> Please review and vote on this PIP.
>>
>> PIP link: https://github.com/apache/pulsar/issues/18319 <https://github.com/apache/pulsar/issues/18319>
>>
>> Discuss thread: https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6 <https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6>
>>
>> Thanks,
>> Tao Jiuming
Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics
Posted by Ran Gao <rg...@apache.org>.
+1 (unbinding)
Thanks,
Ran
On 2022/11/17 09:06:50 Jiuming Tao wrote:
> Dear Pulsar Community,
>
> Please review and vote on this PIP.
>
> PIP link: https://github.com/apache/pulsar/issues/18319 <https://github.com/apache/pulsar/issues/18319>
>
> Discuss thread: https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6 <https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6>
>
> Thanks,
> Tao Jiuming