You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/09/08 20:36:00 UTC

[jira] [Commented] (GEODE-8340) Enforce Switch compiler warnings as errors

    [ https://issues.apache.org/jira/browse/GEODE-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192454#comment-17192454 ] 

ASF subversion and git services commented on GEODE-8340:
--------------------------------------------------------

Commit ea1bb1f350ab29a94c5e374842fe39cc77166d04 in geode-native's branch refs/heads/feature/asio from M. Oleske
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=ea1bb1f ]

GEODE-8340:  Enforce Switch compiler warnings as errors (#625)

- GEODE-8340: Enforce no-covered-switch-default
- GEODE-8340: Enforce no-switch-enum
- GEODE-8340: Enforce no-implicit-fallthrough
- GEODE-8340: Use 4 way if else
- GEODE-8340: Replace switch statement for enum with direct lookup
- GEODE-8340: Use map instead of switch

Co-authored-by: M. Oleske <mi...@oleske.engineer>
Co-authored-by: Blake Bender <bb...@pivotal.io>

> Enforce Switch compiler warnings as errors
> ------------------------------------------
>
>                 Key: GEODE-8340
>                 URL: https://issues.apache.org/jira/browse/GEODE-8340
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Michael Oleske
>            Priority: Major
>              Labels: pull-request-available
>
> Given I compile the code without exempting no-switch-enum and no-implicit-fallthrough and no-covered-switch-default
> Then it should compile
> Note - was marked as a todo, seems reasonable to tackle all these at once



--
This message was sent by Atlassian Jira
(v8.3.4#803005)