[jira] [Comment Edited] (CASSANDRA-12461) Add hooks to StorageService shutdown

["Anthony Cozzie (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446337#comment-15446337 ] 

Anthony Cozzie edited comment on CASSANDRA-12461 at 8/29/16 4:24 PM:
---------------------------------------------------------------------

Ah, good catch.  I think this is a simple fix (logback's context aware doesn't happen in the constructor for some reason), at least it seems to make the error go away for me.  Updated my branches appropriately.

Also, the problem with removing the shutdown hook is that then nothing that we register here will run.  


was (Author: acoz):
Ah, good catch.  I think this is a simple fix (logback's context aware doesn't happen in the constructor for some reason).

Also, the problem with removing the shutdown hook is that then nothing that we register here will run.  

> Add hooks to StorageService shutdown
> ------------------------------------
>
>                 Key: CASSANDRA-12461
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12461
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Anthony Cozzie
>            Assignee: Anthony Cozzie
>         Attachments: 0001-CASSANDRA-12461-add-C-support-for-shutdown-runnables.patch
>
>
> The JVM will usually run shutdown hooks in parallel.  This can lead to synchronization problems between Cassandra, services that depend on it, and services it depends on.  This patch adds some simple support for shutdown hooks to StorageService.
> This should nearly solve CASSANDRA-12011



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)