You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/19 05:38:08 UTC
[GitHub] [incubator-doris] vagetablechicken opened a new pull request #2944:
create pprof_profile_dir before heap profiling
vagetablechicken opened a new pull request #2944: create pprof_profile_dir before heap profiling
URL: https://github.com/apache/incubator-doris/pull/2944
only add
contains clang-format diff
If `config::heap_profile_dir` is no use, I'd like to remove it in this pr.
https://github.com/apache/incubator-doris/blob/feef077520ba9dc843fa900febd43b8ed03c2b66/be/src/service/backend_service.cpp#L76
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] vagetablechicken edited a comment on issue #2944:
create pprof_profile_dir before heap profiling
Posted by GitBox <gi...@apache.org>.
vagetablechicken edited a comment on issue #2944: create pprof_profile_dir before heap profiling
URL: https://github.com/apache/incubator-doris/pull/2944#issuecomment-588157911
> If `heap_profile_dir` is not empty, then the profile will be opened and the performance of the process will be reduced. I estimate that the purpose of the previous configuration is to enable the profile through this configuration. But now you can do it with the `HEAPPROFILE` parameter, you can refer [here](http://doris.apache.org/documentation/cn/developer-guide/debug-tool.html).
> So this thing should be able to be deleted
The two methods, HEAPPROFILE & pprof, are complete. That is why I think heap_profile_dir is useless. I'll delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on issue #2944: create
pprof_profile_dir before heap profiling
Posted by GitBox <gi...@apache.org>.
imay commented on issue #2944: create pprof_profile_dir before heap profiling
URL: https://github.com/apache/incubator-doris/pull/2944#issuecomment-588065768
#2943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2944:
create pprof_profile_dir before heap profiling
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2944: create pprof_profile_dir before heap profiling
URL: https://github.com/apache/incubator-doris/pull/2944#discussion_r381102021
##########
File path: be/src/http/action/pprof_actions.cpp
##########
@@ -243,23 +242,20 @@ void SymbolAction::handle(HttpRequest* req) {
}
Status PprofActions::setup(ExecEnv* exec_env, EvHttpServer* http_server) {
- http_server->register_handler(HttpMethod::GET, "/pprof/heap",
- new HeapAction());
- http_server->register_handler(HttpMethod::GET, "/pprof/growth",
- new GrowthAction());
- http_server->register_handler(HttpMethod::GET, "/pprof/profile",
- new ProfileAction());
- http_server->register_handler(HttpMethod::GET, "/pprof/pmuprofile",
- new PmuProfileAction());
- http_server->register_handler(HttpMethod::GET, "/pprof/contention",
- new ContentionAction());
- http_server->register_handler(HttpMethod::GET, "/pprof/cmdline",
- new CmdlineAction());
+ if (!config::pprof_profile_dir.empty())
+ boost::filesystem::create_directories(config::pprof_profile_dir);
Review comment:
1. better to use {} to enclose the operation
2. better to use FileUtils instead of boost
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #2944: create
pprof_profile_dir before heap profiling
Posted by GitBox <gi...@apache.org>.
imay merged pull request #2944: create pprof_profile_dir before heap profiling
URL: https://github.com/apache/incubator-doris/pull/2944
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] vagetablechicken commented on issue #2944: create
pprof_profile_dir before heap profiling
Posted by GitBox <gi...@apache.org>.
vagetablechicken commented on issue #2944: create pprof_profile_dir before heap profiling
URL: https://github.com/apache/incubator-doris/pull/2944#issuecomment-588157911
> If `heap_profile_dir` is not empty, then the profile will be opened and the performance of the process will be reduced. I estimate that the purpose of the previous configuration is to enable the profile through this configuration. But now you can do it with the `HEAPPROFILE` parameter, you can refer [here](http://doris.apache.org/documentation/cn/developer-guide/debug-tool.html).
> So this thing should be able to be deleted
That is why I think heap_profile_dir is useless. I'll delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org