[GitHub] [couchdb] jaydoane commented on a change in pull request #2800: Distinguish updates

[GitBox <gi...@apache.org>]

jaydoane commented on a change in pull request #2800:
URL: https://github.com/apache/couchdb/pull/2800#discussion_r412393321



##########
File path: src/chttpd/src/chttpd_httpd_handlers.erl
##########
@@ -328,8 +338,14 @@ handler_info('GET', [Db, <<"_design">>, Name | Path], _) ->
         'attachment.name' => filename:join(Path)
     }};
 
-handler_info('PUT', [Db, <<"_design">>, Name | Path], _) ->
-    {'db.design.doc.attachment.write', #{
+handler_info('PUT', [Db, <<"_design">>, Name | Path], Req) ->
+    ActionName = case chttpd:qs_value(Req, "rev") of

Review comment:
       I think `_bulk_docs` may have similar issues, where you can both add new docs and update existing docs in the same request, and would presumably need to inspect each element of the `docs` field to know what's actually going on?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org