[GitHub] spark pull request #12904: [SPARK-15125][SQL] Changing CSV data source mappi...

[falaki <gi...@git.apache.org>]

Github user falaki commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12904#discussion_r83341979
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVParser.scala ---
    @@ -46,6 +46,7 @@ private[sql] abstract class CsvReader(params: CSVOptions, headers: Seq[String])
         settings.setInputBufferSize(params.inputBufferSize)
         settings.setMaxColumns(params.maxColumns)
         settings.setNullValue(params.nullValue)
    +    settings.setEmptyValue("")
    --- End diff --
    
    Hard coding this is not a good idea. Please add a new option in `CSVOption` and pass to the parser. The default value could be `""`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org