You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "findepi (via GitHub)" <gi...@apache.org> on 2024/06/10 14:22:50 UTC
[PR] Update Gradle to 8.8 [iceberg]
findepi opened a new pull request, #10476:
URL: https://github.com/apache/iceberg/pull/10476
This is in preparation for supporting builds on JDK 21. Gradle 8.1.1
does not support running on JDK 21. At least 8.5 is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update Gradle to 8.8 [iceberg]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on code in PR #10476:
URL: https://github.com/apache/iceberg/pull/10476#discussion_r1633343421
##########
.github/workflows/java-ci.yml:
##########
@@ -90,20 +90,26 @@ jobs:
build-checks:
runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ jvm: [8, 11, 17]
Review Comment:
The first commit comes from https://github.com/apache/iceberg/pull/10473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update Gradle to 8.8 [iceberg]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi closed pull request #10476: Update Gradle to 8.8
URL: https://github.com/apache/iceberg/pull/10476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update Gradle to 8.8 [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #10476:
URL: https://github.com/apache/iceberg/pull/10476#issuecomment-2160331173
Semi duplicate of https://github.com/apache/iceberg/pull/8486
@findepi Thanks for raising this, and we're working on getting the Gradle version bumped to a later one. @jbonofre is doing some great work in https://github.com/apache/iceberg/pull/10386 because the rev-api doesn't work with a later version than the one that we're using now.
Some context: This is part of [Iceberg 1.6.0, see devlist](https://lists.apache.org/thread/ymx4kbbfmndmhlrzfrpgzj3hmo6294pv). Upgrading Gradle is also required to bump Parquet because that uses a later version of Jackson, which carries some JDK 17+ specific files, and the current shadow plugin is unable to work with that. See https://github.com/apache/iceberg/pull/10209 for more context.
Once https://github.com/apache/iceberg/pull/10386 goes in, we can bump Gradle 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update Gradle to 8.8 [iceberg]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #10476:
URL: https://github.com/apache/iceberg/pull/10476#issuecomment-2160557067
thanks @Fokko
closing in favor of https://github.com/apache/iceberg/pull/8486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org