You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/14 23:37:42 UTC
[GitHub] [incubator-mxnet] shangz-ai opened a new pull request #18928: Optimize and add support for FP16 input to quantize_v2 operator on GPU
shangz-ai opened a new pull request #18928:
URL: https://github.com/apache/incubator-mxnet/pull/18928
## Description ##
This PR adds optimized implementation for quantize_v2 operator on GPU and supports FP16 input to the operator.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for quantize_v2 op for both quantizing FP32 and FP16 data
- [x] Code is well-documented:
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] Support FP16 input for quantize_v2 op on GPU
- [x] Optimize the performance of quantize_v2 op
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] shangz-ai commented on pull request #18928: Optimize and add support for FP16 input to quantize_v2 operator on GPU
Posted by GitBox <gi...@apache.org>.
shangz-ai commented on pull request #18928:
URL: https://github.com/apache/incubator-mxnet/pull/18928#issuecomment-677714412
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #18928: Optimize and add support for FP16 input to quantize_v2 operator on GPU
Posted by GitBox <gi...@apache.org>.
ptrendx commented on a change in pull request #18928:
URL: https://github.com/apache/incubator-mxnet/pull/18928#discussion_r472394547
##########
File path: python/mxnet/contrib/quantization.py
##########
@@ -266,7 +266,7 @@ def _collect_layer_statistics(mod, data, collector, max_num_examples=None, logge
num_batches = 0
num_examples = 0
for batch in data:
- mod.forward(data_batch=batch, is_train=False)
+ mod.forward(data_batch=batch, is_train=False)
Review comment:
Please remove the trailing whitespaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18928: Optimize and add support for FP16 input to quantize_v2 operator on GPU
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18928:
URL: https://github.com/apache/incubator-mxnet/pull/18928#issuecomment-674311660
Hey @shangz-ai , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-cpu, website, clang, centos-gpu, edge, windows-gpu, sanity, windows-cpu, miscellaneous, centos-cpu, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18928: Optimize and add support for FP16 input to quantize_v2 operator on GPU
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18928:
URL: https://github.com/apache/incubator-mxnet/pull/18928#issuecomment-677714455
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org