You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rg...@apache.org on 2021/11/21 07:30:47 UTC
[logging-log4j2] branch release-2.x updated: LOG4J2-3114 - Enable immediate flush on RollingFileAppender when buffered i/o is not enabled.
This is an automated email from the ASF dual-hosted git repository.
rgoers pushed a commit to branch release-2.x
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
The following commit(s) were added to refs/heads/release-2.x by this push:
new 5e5e598 LOG4J2-3114 - Enable immediate flush on RollingFileAppender when buffered i/o is not enabled.
5e5e598 is described below
commit 5e5e598c09ce5f61153dd5a497d8d31f087f2d20
Author: Ralph Goers <rg...@apache.org>
AuthorDate: Sun Nov 21 00:30:36 2021 -0700
LOG4J2-3114 - Enable immediate flush on RollingFileAppender when buffered i/o is not enabled.
---
.../org/apache/logging/log4j/core/appender/RollingFileAppender.java | 4 ++--
src/changes/changes.xml | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RollingFileAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RollingFileAppender.java
index 1f300a7..ca67369 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RollingFileAppender.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RollingFileAppender.java
@@ -153,8 +153,8 @@ public final class RollingFileAppender extends AbstractOutputStreamAppender<Roll
manager.initialize();
return new RollingFileAppender(getName(), layout, getFilter(), manager, fileName, filePattern,
- isIgnoreExceptions(), isImmediateFlush(), advertise ? getConfiguration().getAdvertiser() : null,
- getPropertyArray());
+ isIgnoreExceptions(), !isBufferedIo || isImmediateFlush(),
+ advertise ? getConfiguration().getAdvertiser() : null, getPropertyArray());
}
public String getAdvertiseUri() {
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 23416f3..3d61f8a 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -107,6 +107,9 @@
Improve PatternLayout performance by reducing unnecessary indirection and branching.
</action>
<!-- FIXES -->
+ <action issue="LOG4J2-3114" dev="rgoers" type="fix" due-to="Barnabas Bodnar">
+ Enable immediate flush on RollingFileAppender when buffered i/o is not enabled.
+ </action>
<action issue="LOG4J2-3168" dev="rgoers" type="fix" due-to="Benjamin Wöster">
Fix bug when file names contain regex characters.
</action>