[jira] [Updated] (HBASE-13839) Fix AssgnmentManagerTmpl.jamon issues (coloring, content etc.)

["Matt Warhaftig (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-13839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Warhaftig updated HBASE-13839:
-----------------------------------
    Attachment: HBASE-13838_post.tiff
                HBASE-13838_pre.tiff

Attached 'HBASE-13838_pre.tiff' and 'HBASE-13838_post.tiff' to show the 'Region In Transition' UI improvements (hopefully got all the enhancements in that single screenshot :-) ).

If you want to recreate, to have long lasting RITs add the following line and split 'TestTable':
{noformat}
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java b/hbase-server/src/main/java/org/a
pache/hadoop/hbase/master/RegionStates.java
index 5528b07..3e37ca5 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
@@ -410,6 +435,7 @@ public class RegionStates {
     updateRegionState(hri, State.OPEN, serverName, openSeqNum);
 
     synchronized (this) {
+      if(hri.getTable().getNameAsString().equals("TestTable")){ return; }
       regionsInTransition.remove(encodedName);
       ServerName oldServerName = regionAssignments.put(hri, serverName);
       if (!serverName.equals(oldServerName)) {
{noformat}

> Fix AssgnmentManagerTmpl.jamon issues (coloring, content etc.)
> --------------------------------------------------------------
>
>                 Key: HBASE-13839
>                 URL: https://issues.apache.org/jira/browse/HBASE-13839
>             Project: HBase
>          Issue Type: Bug
>          Components: master, UI
>    Affects Versions: 1.1.0
>            Reporter: Lars George
>            Assignee: Matt Warhaftig
>              Labels: beginner
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-13838_post.tiff, HBASE-13838_pre.tiff, hbase-13839-v1.patch
>
>
> The template for the RIT in the Master status page, AssignmentManagerTmpl.jamon) has a few issues:
> - The oldest RIT should not be _red_, looks like a failed entry
> The RIT entries should be for example yellow/amber when over the threshold time, and red if 2x the threshold - or red for the oldest once over the threshold.
> - Region count over RIT threshold should only be colored if > 0
> The summary line (first of two) should not be colored unless there is a value > 0 in it.
> - Color is overriden by table-stripped CSS style!
> The Bootstrap stylesheet cancels out the hardcoded coloring! The table-stripped resets the conditional coloring and should be fixed. Best is to use "alert-warning" etc. that come from the Bootstrap theme stylesheet. That should maybe already work in combination with the "table-stripped" from the same.
> - Should sort descending by time
> Currently the list of regions is sorted by encoded region name. Better is to have the table sorted by RIT time descending.
> We should also think about a pagination option for the currently hardcoded 100 entries max. Maybe a separate issue?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)