You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jérémie BORDIER (JIRA)" <ji...@apache.org> on 2009/01/15 23:58:00 UTC
[jira] Created: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
C++ Library Namespaces should be apache::thrift instead of facebook::thrift
---------------------------------------------------------------------------
Key: THRIFT-270
URL: https://issues.apache.org/jira/browse/THRIFT-270
Project: Thrift
Issue Type: Improvement
Components: Library (C++)
Reporter: Jérémie BORDIER
Priority: Minor
The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated THRIFT-270:
----------------------------------
Attachment: THRIFT-270-patchv3.patch
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Priority: Minor
> Attachments: THRIFT-270-patchv2.patch, THRIFT-270-patchv3.patch, THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani resolved THRIFT-270.
-----------------------------------
Resolution: Fixed
comitted
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Assignee: T Jake Luciani
> Priority: Minor
> Attachments: THRIFT-270-patchv2.patch, THRIFT-270-patchv3.patch, THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
Posted by "Jérémie BORDIER (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jérémie BORDIER updated THRIFT-270:
-----------------------------------
Patch Info: [Patch Available]
Patch available.. :)
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Priority: Minor
> Attachments: THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
Posted by "Jérémie BORDIER (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jérémie BORDIER updated THRIFT-270:
-----------------------------------
Attachment: THRIFT-270.cpplib-namespaces.patch
Should fix everything (compiler / lib / test / tutorial ).
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Priority: Minor
> Attachments: THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669231#action_12669231 ]
David Reiss commented on THRIFT-270:
------------------------------------
There are still a few instances under test. Also, this is going to break source compatibility, so please keep an eye on the -user list for people with build problems. Also, can you also update this page <http://wiki.apache.org/thrift/ThriftUsageC++> ?
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Priority: Minor
> Attachments: THRIFT-270-patchv2.patch, THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668016#action_12668016 ]
T Jake Luciani commented on THRIFT-270:
---------------------------------------
Thanks for the patch!
I'll take a look later tonight.
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Priority: Minor
> Attachments: THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani reassigned THRIFT-270:
-------------------------------------
Assignee: T Jake Luciani
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Assignee: T Jake Luciani
> Priority: Minor
> Attachments: THRIFT-270-patchv2.patch, THRIFT-270-patchv3.patch, THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678644#action_12678644 ]
Alexander Shigin commented on THRIFT-270:
-----------------------------------------
Sorry for a late response, but I'm -1 to this patch. I've got two objection:
1. If you break backward compatibility it'll be greate to make some .h file to provide one. You can look at idea in the next snippet:
{code}
namespace XXX {
struct Z {
int x;
};
}
namespace YYY {
using namespace XXX;
}
YYY::Z x;
{code}
2. Why do we need the "apache::" prefix? What's wrong with just thrift::?
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Assignee: T Jake Luciani
> Priority: Minor
> Attachments: THRIFT-270-patchv2.patch, THRIFT-270-patchv3.patch, THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669223#action_12669223 ]
T Jake Luciani commented on THRIFT-270:
---------------------------------------
looks good, though it was missing a test case that was likley added recently.
+1 I'll be committing soon if there are no objections
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Priority: Minor
> Attachments: THRIFT-270-patchv2.patch, THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678825#action_12678825 ]
Kevin Clark commented on THRIFT-270:
------------------------------------
Hi Alexander,
I think the apache:: prefix is a requirement for us to release as an apache incubator project.
The Ruby bindings provided constant delegation from deprecated classes to the new ones in the proper namespace when we made the switchover. I agree it might make sense for the C++ libs as well, though some have argued that because we haven't had a release there's nothing to break. But, de facto, we've got APIs that people are using, so I could support something like that.
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Assignee: T Jake Luciani
> Priority: Minor
> Attachments: THRIFT-270-patchv2.patch, THRIFT-270-patchv3.patch, THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669233#action_12669233 ]
T Jake Luciani commented on THRIFT-270:
---------------------------------------
Ah, got them now.
I'll update the wiki. For sure this will cause some confusion for people who use cpp but better now than later.
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Assignee: T Jake Luciani
> Priority: Minor
> Attachments: THRIFT-270-patchv2.patch, THRIFT-270-patchv3.patch, THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-270) C++ Library Namespaces should be
apache::thrift instead of facebook::thrift
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated THRIFT-270:
----------------------------------
Attachment: THRIFT-270-patchv2.patch
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Priority: Minor
> Attachments: THRIFT-270-patchv2.patch, THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be renammed to apache::thrift, just as the current discussion about Java library namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.