You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/17 14:12:39 UTC

[GitHub] [arrow] HedgehogCode opened a new pull request #8483: ARROW-10333: Get rid of org.apache.arrow.util in vector

HedgehogCode opened a new pull request #8483:
URL: https://github.com/apache/arrow/pull/8483


   The package `org.apache.arrow.util` was present in the artifacts arrow-vector and arrow-vector-memory-core. Split packages are a problem for OSGI and the Java 9+ modules (JPMS).
   
   This PR moves the classes `AutoClosables` and `Collections2` to arrow-memory-core because they are generally useful and have no coupling with arrow-vector.
   The class `DataSizeRoundingUtil` is tighter coupled with arrow-vector and is therefore moved to the package `org.apache.arrow.vector.util`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] liyafan82 closed pull request #8483: ARROW-10333: [Java] Get rid of org.apache.arrow.util in vector

Posted by GitBox <gi...@apache.org>.
liyafan82 closed pull request #8483:
URL: https://github.com/apache/arrow/pull/8483


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] HedgehogCode commented on a change in pull request #8483: ARROW-10333: [Java] Get rid of org.apache.arrow.util in vector

Posted by GitBox <gi...@apache.org>.
HedgehogCode commented on a change in pull request #8483:
URL: https://github.com/apache/arrow/pull/8483#discussion_r508571098



##########
File path: java/vector/src/main/codegen/templates/DenseUnionVector.java
##########
@@ -36,6 +35,7 @@
 import org.apache.arrow.vector.types.pojo.ArrowType;
 import org.apache.arrow.vector.types.pojo.Field;
 import org.apache.arrow.vector.types.pojo.FieldType;
+import org.apache.arrow.vector.util.DataSizeRoundingUtil;

Review comment:
       Sorry about that. Must have happened during the rebasing of my local changes. It's finally fixed now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] HedgehogCode commented on a change in pull request #8483: ARROW-10333: [Java] Get rid of org.apache.arrow.util in vector

Posted by GitBox <gi...@apache.org>.
HedgehogCode commented on a change in pull request #8483:
URL: https://github.com/apache/arrow/pull/8483#discussion_r508412300



##########
File path: java/vector/src/main/codegen/templates/DenseUnionVector.java
##########
@@ -36,6 +35,7 @@
 import org.apache.arrow.vector.types.pojo.ArrowType;
 import org.apache.arrow.vector.types.pojo.Field;
 import org.apache.arrow.vector.types.pojo.FieldType;
+import org.apache.arrow.vector.util.DataSizeRoundingUtil;

Review comment:
       True. I changed it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] liyafan82 commented on a change in pull request #8483: ARROW-10333: [Java] Get rid of org.apache.arrow.util in vector

Posted by GitBox <gi...@apache.org>.
liyafan82 commented on a change in pull request #8483:
URL: https://github.com/apache/arrow/pull/8483#discussion_r508448784



##########
File path: java/vector/src/main/codegen/templates/DenseUnionVector.java
##########
@@ -36,6 +35,7 @@
 import org.apache.arrow.vector.types.pojo.ArrowType;
 import org.apache.arrow.vector.types.pojo.Field;
 import org.apache.arrow.vector.types.pojo.FieldType;
+import org.apache.arrow.vector.util.DataSizeRoundingUtil;

Review comment:
       We need to import it only once




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] liyafan82 commented on pull request #8483: ARROW-10333: [Java] Get rid of org.apache.arrow.util in vector

Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #8483:
URL: https://github.com/apache/arrow/pull/8483#issuecomment-714879637


   Merging. Thanks for the patch @HedgehogCode 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8483: ARROW-10333: [Java] Get rid of org.apache.arrow.util in vector

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8483:
URL: https://github.com/apache/arrow/pull/8483#issuecomment-711020279


   https://issues.apache.org/jira/browse/ARROW-10333


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] liyafan82 commented on a change in pull request #8483: ARROW-10333: [Java] Get rid of org.apache.arrow.util in vector

Posted by GitBox <gi...@apache.org>.
liyafan82 commented on a change in pull request #8483:
URL: https://github.com/apache/arrow/pull/8483#discussion_r508374040



##########
File path: java/vector/src/main/codegen/templates/DenseUnionVector.java
##########
@@ -36,6 +35,7 @@
 import org.apache.arrow.vector.types.pojo.ArrowType;
 import org.apache.arrow.vector.types.pojo.Field;
 import org.apache.arrow.vector.types.pojo.FieldType;
+import org.apache.arrow.vector.util.DataSizeRoundingUtil;

Review comment:
       This line should be placed after the next line, to maintain the import order




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org