[GitHub] [incubator-devlake] klesh commented on pull request #5208: Remove workflow name length validation

["klesh (via GitHub)" <gi...@apache.org>]

klesh commented on PR #5208:
URL: https://github.com/apache/incubator-devlake/pull/5208#issuecomment-1552575118

   Thanks for your contribution. However, changing the `type` only would not be sufficient.
   In order for the existing table and records to be updated, we have to provide a database migration script like [this one](https://github.com/apache/incubator-devlake/blob/243cc8a80aa5b37828e2a142ac9f7e3269b7e1dc/backend/plugins/gitlab/models/migrationscripts/20220906_fix_duration_to_float8.go) and add it to the [register.go](https://github.com/apache/incubator-devlake/blob/348ba7a09c9b99cc61984c9f7c2589d6fde1c0bf/backend/plugins/github/models/migrationscripts/register.go#L39) so it can be picked and executed during boot-up of the `devlake`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org