You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/13 13:02:56 UTC

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9273: implement api v1 for variables

ephraimbuddy commented on a change in pull request #9273:
URL: https://github.com/apache/airflow/pull/9273#discussion_r439737773



##########
File path: airflow/api_connexion/endpoints/variable_endpoint.py
##########
@@ -14,41 +14,76 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+from typing import Optional
 
-# TODO(mik-laj): We have to implement it.
-#     Do you want to help? Please look at: https://github.com/apache/airflow/issues/8142
+from flask import Response, make_response, request
+from marshmallow import ValidationError
 

Review comment:
       ```suggestion
   from connexion import NoContent
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org