[GitHub] [pulsar] wuchenxi123 opened a new pull request #11120: pulsar-function: parallelism send record

[GitBox <gi...@apache.org>]

wuchenxi123 opened a new pull request #11120:
URL: https://github.com/apache/pulsar/pull/11120


    <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
   
   Fixes #<xyz>
   
   *(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
   
   Master Issue: #<xyz>
   
   ### Motivation
   Currently JavaInstanceRunnable uses a single thread to send records asynchronously. Although the Records will not be out of order, there is a problem of inefficiency.
   Considering that in some scenarios, Records processed by Function do not need to guarantee orderliness, so multi-threaded parallel sending can be used to improve sending throughput.
   
   ### Modifications
   1. Using the ThreadPoolExecutor method to achieve concurrent sending of the Record after the Function process
   2. Added numOfSenders multi-threaded sending concurrency configuration, that is, the number of core threads
   1) The default value of numOfSenders is 1, that is, there is only one core thread. At this time, the order of message sending will be guaranteed
   2) When numOfSenders>1, it applies to message sending without guaranteeing orderliness
   3) sendQ implements metrics for sending messages
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage. yes
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no) yes
     - The public API: (yes / no) yes
     - The schema: (yes / no / don't know) yes
     - The default values of configurations: (yes / no) yes
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no) yes
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not documented
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #11120: pulsar-function: parallelism send record

[GitBox <gi...@apache.org>]

codelipenghui commented on pull request #11120:
URL: https://github.com/apache/pulsar/pull/11120#issuecomment-1058888860


   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #11120: pulsar-function: parallelism send record

[GitBox <gi...@apache.org>]

github-actions[bot] commented on pull request #11120:
URL: https://github.com/apache/pulsar/pull/11120#issuecomment-1058889012


   @wuchenxi123:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org