You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 18:46:25 UTC

[GitHub] [flink] kl0u edited a comment on pull request #12224: [FLINK-17594][filesystem] Support Hadoop path-based part-file writer.

kl0u edited a comment on pull request #12224:
URL: https://github.com/apache/flink/pull/12224#issuecomment-630368825


   @gaoyunhaii the changes in the `StreamingFileSink` look good. As long as nothing fails on Azure (we have to wait and see before merging) and given that there was no change required in the tests, I believe that there is no concern about backwards compatibility, so this change is safe.
   
   I have not checked the `flink-hadoop-bulk` module, so someone else can do a more in-depth review on that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org