[PR] [FLINK-37672][build] Migrate protobuf code generation to ascopes plugin [flink]

["MartijnVisser (via GitHub)" <gi...@apache.org>]

MartijnVisser opened a new pull request, #29434:
URL: https://github.com/apache/flink/pull/29434

   ## What is the purpose of the change
   
   Replace protoc-jar-maven-plugin and the archived xolstice protobuf-maven-plugin with [ascopes/protobuf-maven-plugin](https://github.com/ascopes/protobuf-maven-plugin) 3.10.3, instead of the 0.6.1 bump the ticket asked for. This removes the workaround from FLINK-11427 and FLINK-19616 and lets platforms without a protoc on Maven Central build. Nothing that fails in CI today is fixed by this.
   
   ## Brief change log
   
     - Configured once in the root pom. 4.0.0 and later require Java 17, and Flink still builds on JDK 11.
     - `os-maven-plugin`, the `build-helper` executions, `checkStaleness` and the proto timestamps in `unpack_build_artifact.sh` are removed.
     - `-Dprotobuf.compiler.version=PATH` uses a local protoc, e.g. on riscv64.
     - flink-parquet's test protos move to `src/test/proto`, dropping their rat exclude.
   
   ## Verifying this change
   
   This change is already covered by existing tests. In addition, compared against master:
   
     - Generated sources are byte-identical in all three modules on JDK 11 and 17. The flink-python jar is unchanged (all 21,467 entries).
     - flink-protobuf and flink-parquet `verify` give the same test counts.
     - With exec bits stripped from `target/`, master fails with `error=13, Permission denied`, while this branch regenerates.
   
   `mvn compile -pl flink-python` on its own now needs the test-jars flink-python depends on, as flink-parquet already did. Switching back to a branch without this change needs a `clean`, otherwise flink-python can hit a duplicate `FlinkFnApi` class.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes, a build plugin only
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-37672][build] Migrate protobuf code generation to ascopes plugin [flink]

["MartijnVisser (via GitHub)" <gi...@apache.org>]

MartijnVisser merged PR #29434:
URL: https://github.com/apache/flink/pull/29434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-37672][build] Migrate protobuf code generation to ascopes plugin [flink]

["flinkbot (via GitHub)" <gi...@apache.org>]

flinkbot commented on PR #29434:
URL: https://github.com/apache/flink/pull/29434#issuecomment-6061450681

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b2caf587b6ae940f6125350f9c4004b4dc94a4e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0b2caf587b6ae940f6125350f9c4004b4dc94a4e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b2caf587b6ae940f6125350f9c4004b4dc94a4e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org