You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Philippe STRAUSS (JIRA)" <ji...@apache.org> on 2011/09/06 15:57:09 UTC
[jira] [Created] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
------------------------------------------------------------------------------
Key: THRIFT-1326
URL: https://issues.apache.org/jira/browse/THRIFT-1326
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
Reporter: Philippe STRAUSS
Fix For: 0.8
building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell closed THRIFT-1326.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.9
fixed
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Fix For: 0.9
>
> Attachments: THRIFT-1326.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Jake Farrell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159288#comment-13159288 ]
Jake Farrell commented on THRIFT-1326:
--------------------------------------
C99 inttypes.h includes stdint.h, so there's no need to include stdint.h separately. Though on some systems with inttypes.h there is no stdint.h, making it impossible to have a #include stdint.h in Thrift.h. There is no guarantee that where you generate the code you also compile the code so you have to take into account the necessary headers you will need and include them accordingly. This means that we can not have the main configure check help setup the #defines. I guess we could stub out a simple autoconf shell for the cpp lib but this really should be handled by the user and whatever build env they are using. I dont see this as a bug but possibly more a missing documentation for help building clients issue
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell updated THRIFT-1326:
---------------------------------
Attachment: THRIFT-1326.patch
Updated fb303 configure.ac to look for inttypes.h and netinet/in.h
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Attachments: THRIFT-1326.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Roy (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167281#comment-13167281 ]
Roy commented on THRIFT-1326:
-----------------------------
I faced this issue when doing a very standard install and wasted a lot of time trying to resolve. Steps to reproduce:
Download Ubuntu Server 10.04 LTS 64 bit
http://www.ubuntu.com/start-download?distro=server&bits=64&release=lts
Load in VM...
sudo apt-get upgrade
sudo apt-get install build-essential automake libtool pkg-config g++
sudo apt-get install php5 php5-cli php5-dev python python-dev ant openjdk-6-jdk bjam
sudo apt-get install libboost-all-dev libevent-dev flex bison git-core
git clone git://git.apache.org/thrift.git
cd thrift
./bootstrap.sh
./configure
make
sudo make install
cd contrib/fb303
./bootstrap.sh
./configure
make
The above resulted in the following errors (adding for search index to help others find this ticket):
TTransport.h error expected constructor, destructor, or type conversion before readAll
TProtocol.h error âuint32_tâ does not name a type <--not sure whats up with the charset issue
TProtocol.h error uint32_t does not name a type
FacebookService.cpp uint32_t was not declared in this scope
SOLUTION:
sudo nano /usr/local/include/thrift/Thrift.h
Added the following at the bottom of the includes:
#include <inttypes.h>
#include <netinet/in.h>
I see the two #ifdef conditions which should be loading these but there seems to be some sort of issue apparently.
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Jake Farrell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140846#comment-13140846 ]
Jake Farrell commented on THRIFT-1326:
--------------------------------------
Phillippe, i've only seen this error when the cpp lib is not installed and you are trying to reference it (example: using fb303 without cpp lib). I am running on 10.6.8 and 10.7.2 and when cpp lib is installed I have not seen this issue. are you still seeing this problem against trunk when the cpp lib is installed? can you provide some more information about your installed setup and possibly a test showing this issue. Thanks
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Fix For: 0.8
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Roger Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167868#comment-13167868 ]
Roger Meier commented on THRIFT-1326:
-------------------------------------
Do you have the issue with fb303?
Is HAVE_CONFIG_H defined?
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Mike Riley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144850#comment-13144850 ]
Mike Riley commented on THRIFT-1326:
------------------------------------
I had this same issue, as well as a missing include for htonl (netinet/in or arpa/inet depending on your platform). Both of these problems were fixed by just including the macros HAVE_NETINET_IN_H and HAVE_INTTYPES_H when building code that referenced the thrift libraries.
I posted to the user mailing list about this a few days ago, it might be better to put an #ifndef HAVE_CONFIG_H (which is the only instance when those macros won't need to be manually defined) statement in Thrift.h and evaluate which alternatives for inttypes and netinet/in are available.
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Anatoly Kanivetsky (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159940#comment-13159940 ]
Anatoly Kanivetsky commented on THRIFT-1326:
--------------------------------------------
>> C99 inttypes.h includes stdint.h, so there's no need to include stdint.h separately. Though on some systems with inttypes.h there is no stdint.h, making it impossible to have a #include stdint.h in Thrift.h
It sounds like a reasonable concern to avoid including stdint.h directly. But why should we avoid including inttypes.h on all platforms? There are some systems, on which including inttypes.h will break any build, since they includes stdint.h, which is absent on this systems? Or missed something?
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "hellerliu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175692#comment-13175692 ]
hellerliu commented on THRIFT-1326:
-----------------------------------
I have encounter such problems. The compiler complained for not knowing about "uint32_t", "sockaddr_in"
After adding this :
COMMON_DEF=-DHAVE_NETINET_IN_H -DHAVE_INTTYPES_H
to Makefile, the problem is gone.
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Jake Farrell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell updated THRIFT-1326:
---------------------------------
Affects Version/s: 0.7
Fix Version/s: (was: 0.8)
Assignee: Jake Farrell
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Anatoly Kanivetsky (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159154#comment-13159154 ]
Anatoly Kanivetsky commented on THRIFT-1326:
--------------------------------------------
Same issue on ubuntu 11.10:
autoconf (GNU Autoconf) 2.68
automake (GNU automake) 1.11.1
gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1
Adding -DHAVE_INTTYPES_H to my Makefile helps, but it's ugly.
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Roy (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167951#comment-13167951 ]
Roy commented on THRIFT-1326:
-----------------------------
The issue arises with fb303 make, not the thrift make. I did exactly the steps I provided, nothing more or less.
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278604#comment-13278604 ]
Hudson commented on THRIFT-1326:
--------------------------------
Integrated in Thrift #475 (See [https://builds.apache.org/job/Thrift/475/])
Thrift-1326:on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
Client: contrib/fb303
Patch: Jake Farrell
Adding check for needed headers to fb303 configure.ac (Revision 1339969)
Result = ABORTED
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Fix For: 0.9
>
> Attachments: THRIFT-1326.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1326) on some platforms, #include
is necessary to be included in Thrift.h
Posted by "Roger Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168003#comment-13168003 ]
Roger Meier commented on THRIFT-1326:
-------------------------------------
ok, it seems that fb303 does not take care on compiler location from current build and it does not set HAVE_CONFIG_H
se we need a patch for this;-)
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
> Key: THRIFT-1326
> URL: https://issues.apache.org/jira/browse/THRIFT-1326
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift and server code generated by thrift
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> in main Thrift.h to prevent an "error: uint32_t does not define a type" error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include <stdint.h>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira