svn commit: r1005380 - in /commons/proper/lang/trunk: checkstyle.xml pom.xml

[ni...@apache.org]

Author: niallp
Date: Thu Oct  7 09:23:59 2010
New Revision: 1005380

URL: http://svn.apache.org/viewvc?rev=1005380&view=rev
Log:
Upgrade reporting plugin versions and fix issues upgrading maven-checkstyle-plugin from version 2.3 to 2.6

maven-checkstyle-plugin 2.4 onwards uses Checkstyle 5.0 (upgraded from Checkstyle 4.4). Checkstyle 5.0 is not 100% backwardly compatible with release 4.4 and the following changes need to be made to make it work. See the Release Notes for details of incompatible changes and fixes here:
    http://checkstyle.sourceforge.net/releasenotes.html


Modified:
    commons/proper/lang/trunk/checkstyle.xml
    commons/proper/lang/trunk/pom.xml

Modified: commons/proper/lang/trunk/checkstyle.xml
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/checkstyle.xml?rev=1005380&r1=1005379&r2=1005380&view=diff
==============================================================================
--- commons/proper/lang/trunk/checkstyle.xml (original)
+++ commons/proper/lang/trunk/checkstyle.xml Thu Oct  7 09:23:59 2010
@@ -23,9 +23,14 @@ limitations under the License.
 <!-- commons lang customization of default Checkstyle behavior -->
 <module name="Checker">
   <property name="localeLanguage" value="en"/>
-  <module name="PackageHtml"/>
+  <module name="JavadocPackage">
+    <!-- setting allowLegacy means it will check for package.html instead of just package-info.java -->
+    <property name="allowLegacy" value="true"/>
+  </module>
+  <module name="FileTabCharacter">
+    <property name="fileExtensions" value="java,xml"/>
+  </module>
   <module name="TreeWalker">
-    <module name="TabCharacter"/>
     <module name="AvoidStarImport"/>
     <module name="RedundantImport"/>
     <module name="UnusedImports"/>

Modified: commons/proper/lang/trunk/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/pom.xml?rev=1005380&r1=1005379&r2=1005380&view=diff
==============================================================================
--- commons/proper/lang/trunk/pom.xml (original)
+++ commons/proper/lang/trunk/pom.xml Thu Oct  7 09:23:59 2010
@@ -474,7 +474,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-changes-plugin</artifactId>
-          <version>2.0</version>
+          <version>2.3</version>
           <configuration>
             <xmlPath>${basedir}/src/site/changes/changes.xml</xmlPath>
             <issueLinkTemplate>%URL%/%ISSUE%</issueLinkTemplate>
@@ -489,7 +489,7 @@
         </plugin>
       <plugin>
         <artifactId>maven-checkstyle-plugin</artifactId>
-        <version>2.3</version>
+        <version>2.6</version>
         <configuration>
           <configLocation>${basedir}/checkstyle.xml</configLocation>
           <enableRulesSummary>false</enableRulesSummary>
@@ -499,7 +499,7 @@
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>findbugs-maven-plugin</artifactId>
-        <version>1.2</version>
+        <version>2.3.1</version>
         <configuration>
           <threshold>Normal</threshold>
           <effort>Default</effort>
@@ -509,7 +509,7 @@
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>cobertura-maven-plugin</artifactId>
-        <version>2.3</version>
+        <version>2.4</version>
       </plugin>
       <plugin>
         <groupId>org.codehaus.mojo</groupId>