You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/06/15 13:25:52 UTC

[GitHub] [systemds] ywcb00 commented on a change in pull request #1314: [SYSTEMDS-2982] Federated instructions w/ multiple aligned matrices

ywcb00 commented on a change in pull request #1314:
URL: https://github.com/apache/systemds/pull/1314#discussion_r651788108



##########
File path: src/main/java/org/apache/sysds/runtime/instructions/cp/SpoofCPInstruction.java
##########
@@ -138,34 +136,6 @@ public boolean isFederated(ExecutionContext ec) {
 	}
 	
 	public boolean isFederated(ExecutionContext ec, FType type) {

Review comment:
       You're right :)
   I changed it to directly call the static method _isFederated()_ from _SpoofFEDInstruction_ and introduced the getter method _getInputs()_ in _SpoofCPInstruction_ and _SpoofSPInstruction_ to get the inputs for that call.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org