[GitHub] [spark] jaceklaskowski commented on a diff in pull request #40555: [SPARK-42926][BUILD][SQL] Upgrade Parquet to 1.12.4

["jaceklaskowski (via GitHub)" <gi...@apache.org>]

jaceklaskowski commented on code in PR #40555:
URL: https://github.com/apache/spark/pull/40555#discussion_r1149120335


##########
project/SparkBuild.scala:
##########
@@ -307,7 +307,9 @@ object SparkBuild extends PomBuild {
       DefaultMavenRepository,
       Resolver.mavenLocal,
       Resolver.file("ivyLocal", file(Path.userHome.absolutePath + "/.ivy2/local"))(Resolver.ivyStylePatterns)
-    ),
+    ) ++ Seq(
+      "staging-releases-mirror" at "https://repository.apache.org/content/repositories/staging/",

Review Comment:
   Why is this required? Looks like a temporary change to me (to test out the change before parquet is widely available in the public repo).



##########
pom.xml:
##########
@@ -325,6 +325,17 @@
     </extraJavaTestArgs>
   </properties>
   <repositories>
+    <repository>

Review Comment:
   Why is this required?



##########
pom.xml:
##########
@@ -2361,7 +2372,7 @@
             <groupId>${hive.group}</groupId>
             <artifactId>hive-service-rpc</artifactId>
           </exclusion>
-          <!-- parquet-hadoop-bundle:1.8.1 conflict with 1.12.3 -->
+          <!-- parquet-hadoop-bundle:1.8.1 conflict with 1.12.4 -->

Review Comment:
   Rather than "upgrading" the version in the comment (that does not really say much) I'd reword it to the following (and get rid of the version):
   
   ```
   parquet-hadoop-bundle:1.8.1 conflict with [the name of the artifact it conflicts with]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org