You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/05/11 21:36:44 UTC
Re: Review Request 58347: Introduced a filter for test cases that need
thread-safety.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/#review174731
-----------------------------------------------------------
Can you rebase this, please?
- Neil Conway
On April 24, 2017, 11:22 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58347/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 11:22 a.m.)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Bugs: MESOS-7193
> https://issues.apache.org/jira/browse/MESOS-7193
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of using asserts that would fail a test at runtime when
> thread-safety of the test environment isn't given, these tests are now
> filtered out before running the tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd
> 3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de
> 3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa
> 3rdparty/libprocess/src/tests/main.cpp 6ae772416d6a84427d82f4b25b8b26e100426933
> 3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c
> 3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115
> 3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818
>
>
> Diff: https://reviews.apache.org/r/58347/diff/2/
>
>
> Testing
> -------
>
> libprocess-tests (using automake and CMake with macOS, Linux, Windows)
>
>
> Thanks,
>
> Jan Schlicht
>
>