[jira] Issue Comment Edited: (LUCENE-1350) Filters which are "consumers" should not reset the payload or flags and should better reuse the token

["Doron Cohen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621041#action_12621041 ] 

doronc edited comment on LUCENE-1350 at 8/8/08 1:18 PM:
-------------------------------------------------------------

Mike, thanks for clearing things...

You're right - this is fixed by LUCENE-1333. 
If LUCENE-1333 gets committed soon there's no point in 
doing this here, just making more work for DM in reworking 1333.
The only motivation to do this is if there will be another
fix release 2.3.3.3, in which case it would make sense to
fix this issue, but not the deprecation of the non-reuse 
API done by 1333. Or do you agree with DM that since payloads
and flags are marked experimental they can remain broken 
(in regard of this issue) until 2.4? (not perfect, but I can 
live with it).

For the reuse methods names, I like *reinit()*...


      was (Author: doronc):
    Mike, thanks for clearing things...

You're right - this is fixed by LUCENE-1333. 
If LUCENE-1333 gets committed soon there's no point in 
doing this here, just making more work for DM in reworking 1333.
The only motivation to do this is if there will be another
fix release 2.3.3.3, in which case it would make sense to
fix this issue, but not the deprecation of the non-reuse 
API done by 1333. Or do you agree with DM that since payloads
and flags are marked experimental they can remain broken 
(in regard of this issue) until 2.4? (I not perfect, but I can 
live with it).

For the reuse methods names, I like *reinit()*...

  
> Filters which are "consumers" should not reset the payload or flags and should better reuse the token
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1350
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1350
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis, contrib/*
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>             Fix For: 2.3.3
>
>         Attachments: LUCENE-1350.patch
>
>
> Passing tokens with payloads through SnowballFilter results in tokens with no payloads.
> A workaround for this is to apply stemming first and only then run whatever logic creates the payload, but this is not always convenient.
> Other "consumer" filters have similar problem.
> These filters can - and should - reuse the token, by implementing next(Token), effectively also fixing the unwanted resetting.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org