[jira] Commented: (JDO-149) maven console doesnt set properties properly

["karan singh malhi (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/JDO-149?page=comments#action_12330316 ] 

karan singh malhi commented on JDO-149:
---------------------------------------


I am submitting the patches for the maven console issue. The solution is a long one and some more goals can be extracted out of it to make it cleaner.
Meanwhile please test and review the patch and provide feedback.
The plugin.jelly patch has to be applied to ~/.maven/cache/maven-console-plugin-1.1/plugin.jelly

This solution will require an entry in the README.txt file because after checkout from repository, the user will have to apply the plugin.jelly patch for the console to work properly.
Another solution is to copy the plugin.jelly contents and put them in maven.xml in either tck20 or trunk. This way the console goal in the maven.xml will override the one available in plugin.jelly. As a result, the plugin.jelly patch would no longer be required.

PS: the patch for plugin.jelly is created using the linux diff command because plugin.jelly was not part of the svn repository. 

> maven console doesnt set properties properly
> --------------------------------------------
>
>          Key: JDO-149
>          URL: http://issues.apache.org/jira/browse/JDO-149
>      Project: JDO
>         Type: Improvement
>   Components: tck20
>     Reporter: karan singh malhi
>     Priority: Trivial
>  Attachments: console.patch, plugin.jelly.patch
>
> the setProps goal tokenizes properties into some sort of Collection. Maven console does not work very well if we set properties after the console has started. 
> I start maven console using the following command:
> karan@j2ee:~/Projects/jdo/trunk/tck20$ maven -bo -Djdo.tck.cfglist=inheritance1.conf -Djdo.tck.identitytypes=applicationidentity console
> -----------------------------------------------------------------------------------------------------------------------
> This starts the maven console. Then i run the runtck.jdori goal. Below is the partial output:
> jdo2-tck 2.0-SNAPSHOT > [default]
> runtck.jdori
> build:start:
> console:
> console:help:
> setProps:
>     [echo] setProps:
>     [echo] Configurations for this run are "inheritance1.conf". To override this, use -Djdo.tck.cfglist=xxx on the maven command line.
>     [echo] Databases for this run are "derby". To override this, use -Djdo.tck.dblist=xxx on the maven command line.
>     [echo] Identity types for this run are "applicationidentity". To override this, use -Djdo.tck.identitytypes=xxx on the maven command line.
> -------------------------------------------------------------------------------------------------------------------------------
> Then i run it again "notice the [ ] brackets arond the inheritance1.conf, derby and applicationidentity.conf in the [echo] of the setProps goal
> jdo2-tck 2.0-SNAPSHOT > [runtck.jdori]
> runtck.jdori
> setProps:
>     [echo] setProps:
>     [echo] Configurations for this run are "[inheritance1.conf]". To override this, use -Djdo.tck.cfglist=xxx on the maven command line.
>     [echo] Databases for this run are "[derby]". To override this, use -Djdo.tck.dblist=xxx on the maven command line.
>     [echo] Identity types for this run are "[applicationidentity]". To override this, use -Djdo.tck.identitytypes=xxx on the maven command line.
> -----------------------------------------------------------------------------------------------------------------------------------
> If i run it again, this time notice [[  ]] around inheritance1.conf, derby and applicationidentity.conf in the [echo] of the setProps goal.
> jdo2-tck 2.0-SNAPSHOT > [runtck.jdori]
> runtck.jdori
> setProps:
>     [echo] setProps:
>     [echo] Configurations for this run are "[[inheritance1.conf]]". To override this, use -Djdo.tck.cfglist=xxx on the maven command line.
>     [echo] Databases for this run are "[[derby]]". To override this, use -Djdo.tck.dblist=xxx on the maven command line.
>     [echo] Identity types for this run are "[[applicationidentity]]". To override this, use -Djdo.tck.identitytypes=xxx on the maven command line.
> THE RESULT OF THE ABOVE IS THAT THE enhance.prepare goal fails with the following message:
> enhance.prepare:
>     [mkdir] Created dir: /home/karan/Projects/jdo/trunk/tck20/target/enhanced/jdori/[[applicationidentity]]
> org.apache.commons.jelly.JellyTagException: /home/karan/Projects/jdo/trunk/tck20/maven.xml:414:71: <copy> /home/karan/Projects/jdo/trunk/tck20/test/jdo/[[applicationidentity]] not found.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira