[jira] [Comment Edited] (CALCITE-2762) Quidem env variable is always false if its name is separated by dot(".")

["Hongze Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732923#comment-16732923 ] 

Hongze Zhang edited comment on CALCITE-2762 at 1/3/19 12:08 PM:
----------------------------------------------------------------

[~vladimirsitnikov]

Thanks, I believe a test case is possible, but maybe not easy to do.

We at least have 2 ways to test this:

*1*. to write a test case to run Quidem.execute() with *com.google.common.base.Function* (throw an error in the function implementation), then assert error occurred.
*2*. to write a *.iq file including a dot separated env, verify it has value *false* (because the default value is false, the expected value will be true), then fail the test.

*1* is actually testing the method Quidem.execute rather than QuidemTest.getEnv, so IMHO it is not a good test case for Calcite, it is not necessary.
*2* is good, but Quidem currently doesn't have a "if false" support, see line https://github.com/julianhyde/quidem/blob/76bc6d0551d6ced94ffb2a634195e2dcd0627ca5/src/main/java/net/hydromatic/quidem/Quidem.java#L673. Even if it supports "if false", we still need a way to fail the test properly.

Any good ideas on this?


was (Author: zhztheplayer):
[~vladimirsitnikov]

Thanks, I believe a test case is possible, but maybe not easy to do.

We at least have 2 ways to test this:

*1*. to write a test case to run Quidem.execute() with *com.google.common.base.Function*
*2*. to write a *.iq file including a dot separated env, verify it has value *false* (because the default value is false, the expected value will be true), then fail the test.

*1* is actually testing the method Quidem.execute rather than QuidemTest.getEnv, so IMHO it is not a good test case for Calcite, it is not necessary.
*2* is good, but Quidem currently doesn't have a "if false" support, see line https://github.com/julianhyde/quidem/blob/76bc6d0551d6ced94ffb2a634195e2dcd0627ca5/src/main/java/net/hydromatic/quidem/Quidem.java#L673. Even if it supports "if false", we still need a way to fail the test properly.

Any good ideas on this?

> Quidem env variable is always false if its name is separated by dot(".")
> ------------------------------------------------------------------------
>
>                 Key: CALCITE-2762
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2762
>             Project: Calcite
>          Issue Type: Improvement
>    Affects Versions: 1.18.0
>            Reporter: Hongze Zhang
>            Assignee: Julian Hyde
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)