You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2026/08/25 00:21:43 UTC

(superset) 01/01: chore(ci): drop inert SQLALCHEMY_WARN_20 flag from unit-test CI

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch chore/drop-sqlalchemy-warn-20
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 9681dbcb92584f5aceaed6e45a9b1440b23c11be
Author: Superset Dev <de...@superset.apache.org>
AuthorDate: Mon Aug 24 17:21:23 2026 -0700

    chore(ci): drop inert SQLALCHEMY_WARN_20 flag from unit-test CI
    
    The SQLAlchemy 2.0 bump landed in #42803; this env var only had
    meaning under SQLAlchemy 1.4 and is a silent no-op under 2.0.52,
    per the cleanup step in the migration battleplan (discussion #40273).
---
 .github/workflows/superset-python-unittest.yml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/.github/workflows/superset-python-unittest.yml b/.github/workflows/superset-python-unittest.yml
index b723e6afb65..f4a5c003988 100644
--- a/.github/workflows/superset-python-unittest.yml
+++ b/.github/workflows/superset-python-unittest.yml
@@ -53,12 +53,6 @@ jobs:
         python-version: ${{ github.event_name == 'pull_request' && fromJSON('["current"]') || fromJSON('["current", "next"]') }}
     env:
       PYTHONPATH: ${{ github.workspace }}
-      # Promotes the SQLAlchemy 2.0 deprecation warnings already locked in as
-      # errors via pytest.ini's `filterwarnings` to actually run in CI, so a
-      # regression on those fails the build instead of relying on a
-      # contributor remembering to set this locally. See the migration
-      # battleplan: https://github.com/apache/superset/discussions/40273
-      SQLALCHEMY_WARN_20: "1"
     steps:
       - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
         uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1