You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:04:42 UTC
[GitHub] [rocketmq-client-go] 1216114309zpf opened a new pull request #548: [#547] fix bug "it cloud only send one message"
1216114309zpf opened a new pull request #548:
URL: https://github.com/apache/rocketmq-client-go/pull/548
c.close is set to true after rmq client is shutdown and message could
be sent only if c.close is false, therefore it should be set to false
after starting rmq client.
Signed-off-by: pengfei <ju...@alibaba-inc.com>
## What is the purpose of the change
bugfix
## Brief changelog
set c.close to false after rmq client is started
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] xujianhai666 commented on pull request #548: [#547] fix bug "it cloud only send one message"
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on pull request #548:
URL: https://github.com/apache/rocketmq-client-go/pull/548#issuecomment-734102831
not good enough, could u modify the `close lifecycle` implement mechanism ? it is terrible now. @1216114309zpf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vongosling closed pull request #548: [#547] fix bug "it cloud only send one message"
Posted by GitBox <gi...@apache.org>.
vongosling closed pull request #548:
URL: https://github.com/apache/rocketmq-client-go/pull/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] 1216114309zpf commented on pull request #548: [#547] fix bug "it cloud only send one message"
Posted by GitBox <gi...@apache.org>.
1216114309zpf commented on pull request #548:
URL: https://github.com/apache/rocketmq-client-go/pull/548#issuecomment-787402030
> not good enough, could u modify the `close lifecycle` implement mechanism ? it is terrible now. @1216114309zpf
👌let me try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vongosling closed pull request #548: [#547] fix bug "it cloud only send one message"
Posted by GitBox <gi...@apache.org>.
vongosling closed pull request #548:
URL: https://github.com/apache/rocketmq-client-go/pull/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vongosling closed pull request #548: [#547] fix bug "it cloud only send one message"
Posted by GitBox <gi...@apache.org>.
vongosling closed pull request #548:
URL: https://github.com/apache/rocketmq-client-go/pull/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vongosling closed pull request #548: [#547] fix bug "it cloud only send one message"
Posted by GitBox <gi...@apache.org>.
vongosling closed pull request #548:
URL: https://github.com/apache/rocketmq-client-go/pull/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] wenfengwang commented on a change in pull request #548: [#547] fix bug "it cloud only send one message"
Posted by GitBox <gi...@apache.org>.
wenfengwang commented on a change in pull request #548:
URL: https://github.com/apache/rocketmq-client-go/pull/548#discussion_r662699621
##########
File path: internal/client.go
##########
@@ -381,6 +381,8 @@ func (c *rmqClient) Start() {
}
})
})
+ //set c.close to false, or it could send only one message
+ c.close = false
Review comment:
I'm not sure if it result in other problems when re-start, do you have taken a full testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] ShannonDing commented on pull request #548: [#547] fix bug "it cloud only send one message"
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on pull request #548:
URL: https://github.com/apache/rocketmq-client-go/pull/548#issuecomment-783319649
ping @1216114309zpf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org