You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2026/03/08 18:43:08 UTC
Re: [PR] Throw UOE for unsupported MultiPageSinkFactory.createSink(...) overloads [maven-site-plugin]
kwin commented on code in PR #1232:
URL: https://github.com/apache/maven-site-plugin/pull/1232#discussion_r2902251249
##########
src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java:
##########
@@ -147,20 +147,20 @@ public Sink createSink(File outputDirectory, String outputName) {
@Override
public Sink createSink(File arg0, String arg1, String arg2) throws IOException {
- // Not used
- return null;
+ throw new UnsupportedOperationException(
Review Comment:
I clarified why this isn't implemented in the exception message in https://github.com/apache/maven-site-plugin/pull/1232/commits/29795eb374195e5fade3271747f3bd8350181d4b.
##########
src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java:
##########
@@ -147,20 +147,20 @@ public Sink createSink(File outputDirectory, String outputName) {
@Override
public Sink createSink(File arg0, String arg1, String arg2) throws IOException {
Review Comment:
Renamed in https://github.com/apache/maven-site-plugin/pull/1232/commits/29795eb374195e5fade3271747f3bd8350181d4b.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org