You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/22 15:07:45 UTC

[GitHub] [incubator-mxnet] sxjscience commented on a change in pull request #18136: [numpy] Fix ffi split

sxjscience commented on a change in pull request #18136:
URL: https://github.com/apache/incubator-mxnet/pull/18136#discussion_r413065974



##########
File path: python/mxnet/ndarray/numpy/_op.py
##########
@@ -3901,6 +3901,8 @@ def split(ary, indices_or_sections, axis=0):
         If `indices_or_sections` is given as an integer, but
         a split does not result in equal division.
     """
+    while axis < 0:
+        axis += len(ary.shape)

Review comment:
       This will fail in the symbolic mode. Do we also test in the symbolic mode?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org