You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/03/29 12:21:42 UTC

[GitHub] [pulsar] sijie opened a new pull request #3940: [schema] store schema type correctly in schema registry

sijie opened a new pull request #3940: [schema] store schema type correctly in schema registry
URL: https://github.com/apache/pulsar/pull/3940
 
 
   *Motivation*
   
   Fixes #3925
   
   We have 3 places of defining schema type enums. We kept adding
   new schema type in pulsar-common. However we don't update the schema type
   in wire protocol and schema storage.
   
   This causes `SchemaType.NONE` is stored in SchemaRegistry.
   It fails debeizum connector on restarting.
   
   *Modifications*
   
   Make sure all 3 places have consistent schema type definitions.
   Record the correct schema type.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (yes)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services