You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by ga...@apache.org on 2010/11/11 12:55:51 UTC

svn commit: r1033903 - /shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsRewriter.java

Author: gagan
Date: Thu Nov 11 11:55:50 2010
New Revision: 1033903

URL: http://svn.apache.org/viewvc?rev=1033903&view=rev
Log:
Patch by gagan.goku | Issue 2770041: Refactoring StyleTagProxyEmbeddedUrlsRewriter to use DefaultConfig instead | http://codereview.appspot.com/2770041/

Modified:
    shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsRewriter.java

Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsRewriter.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsRewriter.java?rev=1033903&r1=1033902&r2=1033903&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsRewriter.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsRewriter.java Thu Nov 11 11:55:50 2010
@@ -19,6 +19,7 @@
 package org.apache.shindig.gadgets.rewrite;
 
 import com.google.inject.Inject;
+
 import org.apache.shindig.common.uri.Uri;
 import org.apache.shindig.gadgets.Gadget;
 import org.apache.shindig.gadgets.uri.ProxyUriManager;
@@ -33,22 +34,21 @@ import java.util.List;
  * @since 2.0.0
  */
 public class StyleTagProxyEmbeddedUrlsRewriter extends DomWalker.Rewriter {
-  private final ContentRewriterFeature.Factory featureConfigFactory;
+  private final ContentRewriterFeature.Config config;
   private final ProxyUriManager proxyUriManager;
   private final CssResponseRewriter cssRewriter;
 
   @Inject
-  public StyleTagProxyEmbeddedUrlsRewriter(ContentRewriterFeature.Factory featureConfigFactory,
+  public StyleTagProxyEmbeddedUrlsRewriter(ContentRewriterFeature.DefaultConfig config,
                                            ProxyUriManager proxyUriManager,
                                            CssResponseRewriter cssRewriter) {
-    this.featureConfigFactory = featureConfigFactory;
+    this.config = config;
     this.proxyUriManager = proxyUriManager;
     this.cssRewriter = cssRewriter;
   }
 
   @Override
   protected List<DomWalker.Visitor> makeVisitors(Gadget context, Uri gadgetUri) {
-    ContentRewriterFeature.Config config = featureConfigFactory.get(gadgetUri);
     return Arrays.<DomWalker.Visitor>asList(
         new StyleTagProxyEmbeddedUrlsVisitor(config, proxyUriManager,
                                              cssRewriter));