You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/07/29 12:23:03 UTC

[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning opened a new pull request, #70: update doc links and reduce Akka links

pjfanning opened a new pull request, #70:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/70

   * include build instructions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning commented on a diff in pull request #70: update doc links and reduce Akka links

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/70#discussion_r1278304235


##########
CONTRIBUTING.md:
##########
@@ -78,25 +74,25 @@ All documentation must abide by the following maxims:
 - Generation should be **completely automated** and available for scripting.
 - Artifacts that must be included in the Typesafe stack should be published to a maven “documentation” repository as documentation artifacts.
 
-All documentation is preferred to be in Typesafe's standard documentation format [reStructuredText](http://doc.akka.io/docs/akka/snapshot/dev/documentation.html) compiled using Typesafe's customized [Sphinx](http://sphinx.pocoo.org/) based documentation generation system, which among other things allows all code in the documentation to be externalized into compiled files and imported into the documentation.
+All documentation is preferred to be in Typesafe's standard documentation format [reStructuredText](https://docutils.sourceforge.io/rst.html) compiled using Typesafe's customized [Sphinx](https://www.sphinx-doc.org/en/master/) based documentation generation system, which among other things allows all code in the documentation to be externalized into compiled files and imported into the documentation.

Review Comment:
   Good point. I have replaced that section with a new one that better describes the current situation.
   
   At some stage in the future, we should add docs that are published to the Pekko web site but I don't want to block a 1.0.0 release over this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning merged pull request #70: update doc links and reduce Akka links

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #70:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/70


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-persistence-dynamodb] He-Pin commented on a diff in pull request #70: update doc links and reduce Akka links

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/70#discussion_r1278302653


##########
CONTRIBUTING.md:
##########
@@ -78,25 +74,25 @@ All documentation must abide by the following maxims:
 - Generation should be **completely automated** and available for scripting.
 - Artifacts that must be included in the Typesafe stack should be published to a maven “documentation” repository as documentation artifacts.
 
-All documentation is preferred to be in Typesafe's standard documentation format [reStructuredText](http://doc.akka.io/docs/akka/snapshot/dev/documentation.html) compiled using Typesafe's customized [Sphinx](http://sphinx.pocoo.org/) based documentation generation system, which among other things allows all code in the documentation to be externalized into compiled files and imported into the documentation.
+All documentation is preferred to be in Typesafe's standard documentation format [reStructuredText](https://docutils.sourceforge.io/rst.html) compiled using Typesafe's customized [Sphinx](https://www.sphinx-doc.org/en/master/) based documentation generation system, which among other things allows all code in the documentation to be externalized into compiled files and imported into the documentation.

Review Comment:
   I don't find any document files in this project, is this statement still applied?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org