You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/06/21 19:15:51 UTC
[kudu-CR] thirdparty: fix build-if-necessary in tarballs
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13706
to review the following change.
Change subject: thirdparty: fix build-if-necessary in tarballs
......................................................................
thirdparty: fix build-if-necessary in tarballs
build-if-necessary, when run from a tarball, uses a build stamp file for
each build configuration to know whether it needs to re-run. However,
a normal build will build both 'common' and then 'tsan' configurations,
in that order. When we go back to check whether 'common' needs a
rebuild, we'll see the tsan build-stamp file and think it needs to be
rebuilt.
This fixes the check to exclude other build-stamp files.
Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
---
M thirdparty/build-if-necessary.sh
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/13706/1
--
To view, visit http://gerrit.cloudera.org:8080/13706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
Gerrit-Change-Number: 13706
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] thirdparty: fix build-if-necessary in tarballs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13706 )
Change subject: thirdparty: fix build-if-necessary in tarballs
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
Gerrit-Change-Number: 13706
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 21 Jun 2019 19:18:31 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: fix build-if-necessary in tarballs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13706 )
Change subject: thirdparty: fix build-if-necessary in tarballs
......................................................................
thirdparty: fix build-if-necessary in tarballs
build-if-necessary, when run from a tarball, uses a build stamp file for
each build configuration to know whether it needs to re-run. However,
a normal build will build both 'common' and then 'tsan' configurations,
in that order. When we go back to check whether 'common' needs a
rebuild, we'll see the tsan build-stamp file and think it needs to be
rebuilt.
This fixes the check to exclude other build-stamp files.
Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
Reviewed-on: http://gerrit.cloudera.org:8080/13706
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M thirdparty/build-if-necessary.sh
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
Gerrit-Change-Number: 13706
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)