You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by jb...@apache.org on 2015/05/26 20:15:06 UTC

[01/10] cassandra git commit: Fix counting cache serialization in request metrics patch by Sankalp Kohli; reviewed by jbellis for CASSANDRA-9466

Repository: cassandra
Updated Branches:
  refs/heads/cassandra-2.0 2beb66e87 -> 04287d440
  refs/heads/cassandra-2.1 4e2691110 -> e0ea4fbee
  refs/heads/cassandra-2.2 6734e94b8 -> 642a453a4
  refs/heads/trunk 5e7cdc2cb -> 98b950fad


Fix counting cache serialization in request metrics
patch by Sankalp Kohli; reviewed by jbellis for CASSANDRA-9466


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/04287d44
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/04287d44
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/04287d44

Branch: refs/heads/cassandra-2.0
Commit: 04287d440a00d5d13c948007cd01954b782da05a
Parents: 2beb66e
Author: Jonathan Ellis <jb...@apache.org>
Authored: Tue May 26 13:13:38 2015 -0500
Committer: Jonathan Ellis <jb...@apache.org>
Committed: Tue May 26 13:13:38 2015 -0500

----------------------------------------------------------------------
 CHANGES.txt                                             | 1 +
 src/java/org/apache/cassandra/service/CacheService.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/04287d44/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index cf124b4..0bff87b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.0.16:
+ * Fix counting cache serialization in request metrics (CASSANDRA-9466)
  * (cqlsh) Add LOGIN command to switch users (CASSANDRA-7212)
  * Clone SliceQueryFilter in AbstractReadCommand implementations (CASSANDRA-8940)
  * Push correct protocol notification for DROP INDEX (CASSANDRA-9310)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/04287d44/src/java/org/apache/cassandra/service/CacheService.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/service/CacheService.java b/src/java/org/apache/cassandra/service/CacheService.java
index f626e17..cf0db97 100644
--- a/src/java/org/apache/cassandra/service/CacheService.java
+++ b/src/java/org/apache/cassandra/service/CacheService.java
@@ -335,7 +335,7 @@ public class CacheService implements CacheServiceMBean
     {
         public void serialize(KeyCacheKey key, DataOutput out) throws IOException
         {
-            RowIndexEntry entry = CacheService.instance.keyCache.get(key);
+            RowIndexEntry entry = CacheService.instance.keyCache.getInternal(key);
             if (entry == null)
                 return;
             ByteBufferUtil.writeWithLength(key.key, out);


[05/10] cassandra git commit: merge from 2.0

Posted by jb...@apache.org.
merge from 2.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/e0ea4fbe
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/e0ea4fbe
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/e0ea4fbe

Branch: refs/heads/cassandra-2.2
Commit: e0ea4fbee8d09a48977d5de0be73088bcf18e712
Parents: 4e26911 04287d4
Author: Jonathan Ellis <jb...@apache.org>
Authored: Tue May 26 13:14:07 2015 -0500
Committer: Jonathan Ellis <jb...@apache.org>
Committed: Tue May 26 13:14:07 2015 -0500

----------------------------------------------------------------------
 CHANGES.txt                                             | 1 +
 src/java/org/apache/cassandra/service/CacheService.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/e0ea4fbe/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index a4430c0,0bff87b..cea6135
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,34 -1,5 +1,35 @@@
 -2.0.16:
 +2.1.6
 + * (cqlsh) Better float precision by default (CASSANDRA-9224)
 + * Improve estimated row count (CASSANDRA-9107)
 + * Optimize range tombstone memory footprint (CASSANDRA-8603)
 + * Use configured gcgs in anticompaction (CASSANDRA-9397)
 + * Warn on misuse of unlogged batches (CASSANDRA-9282)
 + * Failure detector detects and ignores local pauses (CASSANDRA-9183)
 + * Add utility class to support for rate limiting a given log statement (CASSANDRA-9029)
 + * Add missing consistency levels to cassandra-stess (CASSANDRA-9361)
 + * Fix commitlog getCompletedTasks to not increment (CASSANDRA-9339)
 + * Fix for harmless exceptions logged as ERROR (CASSANDRA-8564)
 + * Delete processed sstables in sstablesplit/sstableupgrade (CASSANDRA-8606)
 + * Improve sstable exclusion from partition tombstones (CASSANDRA-9298)
 + * Validate the indexed column rather than the cell's contents for 2i (CASSANDRA-9057)
 + * Add support for top-k custom 2i queries (CASSANDRA-8717)
 + * Fix error when dropping table during compaction (CASSANDRA-9251)
 + * cassandra-stress supports validation operations over user profiles (CASSANDRA-8773)
 + * Add support for rate limiting log messages (CASSANDRA-9029)
 + * Log the partition key with tombstone warnings (CASSANDRA-8561)
 + * Reduce runWithCompactionsDisabled poll interval to 1ms (CASSANDRA-9271)
 + * Fix PITR commitlog replay (CASSANDRA-9195)
 + * GCInspector logs very different times (CASSANDRA-9124)
 + * Fix deleting from an empty list (CASSANDRA-9198)
 + * Update tuple and collection types that use a user-defined type when that UDT
 +   is modified (CASSANDRA-9148, CASSANDRA-9192)
 + * Use higher timeout for prepair and snapshot in repair (CASSANDRA-9261)
 + * Fix anticompaction blocking ANTI_ENTROPY stage (CASSANDRA-9151)
 + * Repair waits for anticompaction to finish (CASSANDRA-9097)
 + * Fix streaming not holding ref when stream error (CASSANDRA-9295)
 + * Fix canonical view returning early opened SSTables (CASSANDRA-9396)
 +Merged from 2.0:
+  * Fix counting cache serialization in request metrics (CASSANDRA-9466)
   * (cqlsh) Add LOGIN command to switch users (CASSANDRA-7212)
   * Clone SliceQueryFilter in AbstractReadCommand implementations (CASSANDRA-8940)
   * Push correct protocol notification for DROP INDEX (CASSANDRA-9310)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/e0ea4fbe/src/java/org/apache/cassandra/service/CacheService.java
----------------------------------------------------------------------
diff --cc src/java/org/apache/cassandra/service/CacheService.java
index 48c0941,cf0db97..a43d6d5
--- a/src/java/org/apache/cassandra/service/CacheService.java
+++ b/src/java/org/apache/cassandra/service/CacheService.java
@@@ -460,22 -331,18 +460,22 @@@ public class CacheService implements Ca
          }
      }
  
 -    public class KeyCacheSerializer implements CacheSerializer<KeyCacheKey, RowIndexEntry>
 +    public static class KeyCacheSerializer implements CacheSerializer<KeyCacheKey, RowIndexEntry>
      {
 -        public void serialize(KeyCacheKey key, DataOutput out) throws IOException
 +        public void serialize(KeyCacheKey key, DataOutputPlus out) throws IOException
          {
-             RowIndexEntry entry = CacheService.instance.keyCache.get(key);
+             RowIndexEntry entry = CacheService.instance.keyCache.getInternal(key);
              if (entry == null)
                  return;
 +
 +            CFMetaData cfm = Schema.instance.getCFMetaData(key.cfId);
 +            if (cfm == null)
 +                return; // the table no longer exists.
 +
              ByteBufferUtil.writeWithLength(key.key, out);
 -            Descriptor desc = key.desc;
 -            out.writeInt(desc.generation);
 +            out.writeInt(key.desc.generation);
              out.writeBoolean(true);
 -            RowIndexEntry.serializer.serialize(entry, out);
 +            cfm.comparator.rowIndexEntrySerializer().serialize(entry, out);
          }
  
          public Future<Pair<KeyCacheKey, RowIndexEntry>> deserialize(DataInputStream input, ColumnFamilyStore cfs) throws IOException


[10/10] cassandra git commit: Merge branch 'cassandra-2.2' into trunk

Posted by jb...@apache.org.
Merge branch 'cassandra-2.2' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/98b950fa
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/98b950fa
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/98b950fa

Branch: refs/heads/trunk
Commit: 98b950fad40b232b166a532f8891ca2dfaa6b225
Parents: 5e7cdc2 642a453
Author: Jonathan Ellis <jb...@apache.org>
Authored: Tue May 26 13:14:55 2015 -0500
Committer: Jonathan Ellis <jb...@apache.org>
Committed: Tue May 26 13:14:55 2015 -0500

----------------------------------------------------------------------
 CHANGES.txt                                             | 1 +
 src/java/org/apache/cassandra/service/CacheService.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/98b950fa/CHANGES.txt
----------------------------------------------------------------------


[04/10] cassandra git commit: Fix counting cache serialization in request metrics patch by Sankalp Kohli; reviewed by jbellis for CASSANDRA-9466

Posted by jb...@apache.org.
Fix counting cache serialization in request metrics
patch by Sankalp Kohli; reviewed by jbellis for CASSANDRA-9466


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/04287d44
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/04287d44
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/04287d44

Branch: refs/heads/trunk
Commit: 04287d440a00d5d13c948007cd01954b782da05a
Parents: 2beb66e
Author: Jonathan Ellis <jb...@apache.org>
Authored: Tue May 26 13:13:38 2015 -0500
Committer: Jonathan Ellis <jb...@apache.org>
Committed: Tue May 26 13:13:38 2015 -0500

----------------------------------------------------------------------
 CHANGES.txt                                             | 1 +
 src/java/org/apache/cassandra/service/CacheService.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/04287d44/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index cf124b4..0bff87b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.0.16:
+ * Fix counting cache serialization in request metrics (CASSANDRA-9466)
  * (cqlsh) Add LOGIN command to switch users (CASSANDRA-7212)
  * Clone SliceQueryFilter in AbstractReadCommand implementations (CASSANDRA-8940)
  * Push correct protocol notification for DROP INDEX (CASSANDRA-9310)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/04287d44/src/java/org/apache/cassandra/service/CacheService.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/service/CacheService.java b/src/java/org/apache/cassandra/service/CacheService.java
index f626e17..cf0db97 100644
--- a/src/java/org/apache/cassandra/service/CacheService.java
+++ b/src/java/org/apache/cassandra/service/CacheService.java
@@ -335,7 +335,7 @@ public class CacheService implements CacheServiceMBean
     {
         public void serialize(KeyCacheKey key, DataOutput out) throws IOException
         {
-            RowIndexEntry entry = CacheService.instance.keyCache.get(key);
+            RowIndexEntry entry = CacheService.instance.keyCache.getInternal(key);
             if (entry == null)
                 return;
             ByteBufferUtil.writeWithLength(key.key, out);


[06/10] cassandra git commit: merge from 2.0

Posted by jb...@apache.org.
merge from 2.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/e0ea4fbe
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/e0ea4fbe
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/e0ea4fbe

Branch: refs/heads/cassandra-2.1
Commit: e0ea4fbee8d09a48977d5de0be73088bcf18e712
Parents: 4e26911 04287d4
Author: Jonathan Ellis <jb...@apache.org>
Authored: Tue May 26 13:14:07 2015 -0500
Committer: Jonathan Ellis <jb...@apache.org>
Committed: Tue May 26 13:14:07 2015 -0500

----------------------------------------------------------------------
 CHANGES.txt                                             | 1 +
 src/java/org/apache/cassandra/service/CacheService.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/e0ea4fbe/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index a4430c0,0bff87b..cea6135
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,34 -1,5 +1,35 @@@
 -2.0.16:
 +2.1.6
 + * (cqlsh) Better float precision by default (CASSANDRA-9224)
 + * Improve estimated row count (CASSANDRA-9107)
 + * Optimize range tombstone memory footprint (CASSANDRA-8603)
 + * Use configured gcgs in anticompaction (CASSANDRA-9397)
 + * Warn on misuse of unlogged batches (CASSANDRA-9282)
 + * Failure detector detects and ignores local pauses (CASSANDRA-9183)
 + * Add utility class to support for rate limiting a given log statement (CASSANDRA-9029)
 + * Add missing consistency levels to cassandra-stess (CASSANDRA-9361)
 + * Fix commitlog getCompletedTasks to not increment (CASSANDRA-9339)
 + * Fix for harmless exceptions logged as ERROR (CASSANDRA-8564)
 + * Delete processed sstables in sstablesplit/sstableupgrade (CASSANDRA-8606)
 + * Improve sstable exclusion from partition tombstones (CASSANDRA-9298)
 + * Validate the indexed column rather than the cell's contents for 2i (CASSANDRA-9057)
 + * Add support for top-k custom 2i queries (CASSANDRA-8717)
 + * Fix error when dropping table during compaction (CASSANDRA-9251)
 + * cassandra-stress supports validation operations over user profiles (CASSANDRA-8773)
 + * Add support for rate limiting log messages (CASSANDRA-9029)
 + * Log the partition key with tombstone warnings (CASSANDRA-8561)
 + * Reduce runWithCompactionsDisabled poll interval to 1ms (CASSANDRA-9271)
 + * Fix PITR commitlog replay (CASSANDRA-9195)
 + * GCInspector logs very different times (CASSANDRA-9124)
 + * Fix deleting from an empty list (CASSANDRA-9198)
 + * Update tuple and collection types that use a user-defined type when that UDT
 +   is modified (CASSANDRA-9148, CASSANDRA-9192)
 + * Use higher timeout for prepair and snapshot in repair (CASSANDRA-9261)
 + * Fix anticompaction blocking ANTI_ENTROPY stage (CASSANDRA-9151)
 + * Repair waits for anticompaction to finish (CASSANDRA-9097)
 + * Fix streaming not holding ref when stream error (CASSANDRA-9295)
 + * Fix canonical view returning early opened SSTables (CASSANDRA-9396)
 +Merged from 2.0:
+  * Fix counting cache serialization in request metrics (CASSANDRA-9466)
   * (cqlsh) Add LOGIN command to switch users (CASSANDRA-7212)
   * Clone SliceQueryFilter in AbstractReadCommand implementations (CASSANDRA-8940)
   * Push correct protocol notification for DROP INDEX (CASSANDRA-9310)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/e0ea4fbe/src/java/org/apache/cassandra/service/CacheService.java
----------------------------------------------------------------------
diff --cc src/java/org/apache/cassandra/service/CacheService.java
index 48c0941,cf0db97..a43d6d5
--- a/src/java/org/apache/cassandra/service/CacheService.java
+++ b/src/java/org/apache/cassandra/service/CacheService.java
@@@ -460,22 -331,18 +460,22 @@@ public class CacheService implements Ca
          }
      }
  
 -    public class KeyCacheSerializer implements CacheSerializer<KeyCacheKey, RowIndexEntry>
 +    public static class KeyCacheSerializer implements CacheSerializer<KeyCacheKey, RowIndexEntry>
      {
 -        public void serialize(KeyCacheKey key, DataOutput out) throws IOException
 +        public void serialize(KeyCacheKey key, DataOutputPlus out) throws IOException
          {
-             RowIndexEntry entry = CacheService.instance.keyCache.get(key);
+             RowIndexEntry entry = CacheService.instance.keyCache.getInternal(key);
              if (entry == null)
                  return;
 +
 +            CFMetaData cfm = Schema.instance.getCFMetaData(key.cfId);
 +            if (cfm == null)
 +                return; // the table no longer exists.
 +
              ByteBufferUtil.writeWithLength(key.key, out);
 -            Descriptor desc = key.desc;
 -            out.writeInt(desc.generation);
 +            out.writeInt(key.desc.generation);
              out.writeBoolean(true);
 -            RowIndexEntry.serializer.serialize(entry, out);
 +            cfm.comparator.rowIndexEntrySerializer().serialize(entry, out);
          }
  
          public Future<Pair<KeyCacheKey, RowIndexEntry>> deserialize(DataInputStream input, ColumnFamilyStore cfs) throws IOException


[09/10] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2

Posted by jb...@apache.org.
Merge branch 'cassandra-2.1' into cassandra-2.2


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/642a453a
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/642a453a
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/642a453a

Branch: refs/heads/trunk
Commit: 642a453a435653b2b7f5a8e0f822c9f6de55adb2
Parents: 6734e94 e0ea4fb
Author: Jonathan Ellis <jb...@apache.org>
Authored: Tue May 26 13:14:26 2015 -0500
Committer: Jonathan Ellis <jb...@apache.org>
Committed: Tue May 26 13:14:26 2015 -0500

----------------------------------------------------------------------
 CHANGES.txt                                             | 1 +
 src/java/org/apache/cassandra/service/CacheService.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/642a453a/CHANGES.txt
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/cassandra/blob/642a453a/src/java/org/apache/cassandra/service/CacheService.java
----------------------------------------------------------------------


[08/10] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2

Posted by jb...@apache.org.
Merge branch 'cassandra-2.1' into cassandra-2.2


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/642a453a
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/642a453a
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/642a453a

Branch: refs/heads/cassandra-2.2
Commit: 642a453a435653b2b7f5a8e0f822c9f6de55adb2
Parents: 6734e94 e0ea4fb
Author: Jonathan Ellis <jb...@apache.org>
Authored: Tue May 26 13:14:26 2015 -0500
Committer: Jonathan Ellis <jb...@apache.org>
Committed: Tue May 26 13:14:26 2015 -0500

----------------------------------------------------------------------
 CHANGES.txt                                             | 1 +
 src/java/org/apache/cassandra/service/CacheService.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/642a453a/CHANGES.txt
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/cassandra/blob/642a453a/src/java/org/apache/cassandra/service/CacheService.java
----------------------------------------------------------------------


[02/10] cassandra git commit: Fix counting cache serialization in request metrics patch by Sankalp Kohli; reviewed by jbellis for CASSANDRA-9466

Posted by jb...@apache.org.
Fix counting cache serialization in request metrics
patch by Sankalp Kohli; reviewed by jbellis for CASSANDRA-9466


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/04287d44
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/04287d44
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/04287d44

Branch: refs/heads/cassandra-2.1
Commit: 04287d440a00d5d13c948007cd01954b782da05a
Parents: 2beb66e
Author: Jonathan Ellis <jb...@apache.org>
Authored: Tue May 26 13:13:38 2015 -0500
Committer: Jonathan Ellis <jb...@apache.org>
Committed: Tue May 26 13:13:38 2015 -0500

----------------------------------------------------------------------
 CHANGES.txt                                             | 1 +
 src/java/org/apache/cassandra/service/CacheService.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/04287d44/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index cf124b4..0bff87b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.0.16:
+ * Fix counting cache serialization in request metrics (CASSANDRA-9466)
  * (cqlsh) Add LOGIN command to switch users (CASSANDRA-7212)
  * Clone SliceQueryFilter in AbstractReadCommand implementations (CASSANDRA-8940)
  * Push correct protocol notification for DROP INDEX (CASSANDRA-9310)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/04287d44/src/java/org/apache/cassandra/service/CacheService.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/service/CacheService.java b/src/java/org/apache/cassandra/service/CacheService.java
index f626e17..cf0db97 100644
--- a/src/java/org/apache/cassandra/service/CacheService.java
+++ b/src/java/org/apache/cassandra/service/CacheService.java
@@ -335,7 +335,7 @@ public class CacheService implements CacheServiceMBean
     {
         public void serialize(KeyCacheKey key, DataOutput out) throws IOException
         {
-            RowIndexEntry entry = CacheService.instance.keyCache.get(key);
+            RowIndexEntry entry = CacheService.instance.keyCache.getInternal(key);
             if (entry == null)
                 return;
             ByteBufferUtil.writeWithLength(key.key, out);


[07/10] cassandra git commit: merge from 2.0

Posted by jb...@apache.org.
merge from 2.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/e0ea4fbe
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/e0ea4fbe
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/e0ea4fbe

Branch: refs/heads/trunk
Commit: e0ea4fbee8d09a48977d5de0be73088bcf18e712
Parents: 4e26911 04287d4
Author: Jonathan Ellis <jb...@apache.org>
Authored: Tue May 26 13:14:07 2015 -0500
Committer: Jonathan Ellis <jb...@apache.org>
Committed: Tue May 26 13:14:07 2015 -0500

----------------------------------------------------------------------
 CHANGES.txt                                             | 1 +
 src/java/org/apache/cassandra/service/CacheService.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/e0ea4fbe/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index a4430c0,0bff87b..cea6135
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,34 -1,5 +1,35 @@@
 -2.0.16:
 +2.1.6
 + * (cqlsh) Better float precision by default (CASSANDRA-9224)
 + * Improve estimated row count (CASSANDRA-9107)
 + * Optimize range tombstone memory footprint (CASSANDRA-8603)
 + * Use configured gcgs in anticompaction (CASSANDRA-9397)
 + * Warn on misuse of unlogged batches (CASSANDRA-9282)
 + * Failure detector detects and ignores local pauses (CASSANDRA-9183)
 + * Add utility class to support for rate limiting a given log statement (CASSANDRA-9029)
 + * Add missing consistency levels to cassandra-stess (CASSANDRA-9361)
 + * Fix commitlog getCompletedTasks to not increment (CASSANDRA-9339)
 + * Fix for harmless exceptions logged as ERROR (CASSANDRA-8564)
 + * Delete processed sstables in sstablesplit/sstableupgrade (CASSANDRA-8606)
 + * Improve sstable exclusion from partition tombstones (CASSANDRA-9298)
 + * Validate the indexed column rather than the cell's contents for 2i (CASSANDRA-9057)
 + * Add support for top-k custom 2i queries (CASSANDRA-8717)
 + * Fix error when dropping table during compaction (CASSANDRA-9251)
 + * cassandra-stress supports validation operations over user profiles (CASSANDRA-8773)
 + * Add support for rate limiting log messages (CASSANDRA-9029)
 + * Log the partition key with tombstone warnings (CASSANDRA-8561)
 + * Reduce runWithCompactionsDisabled poll interval to 1ms (CASSANDRA-9271)
 + * Fix PITR commitlog replay (CASSANDRA-9195)
 + * GCInspector logs very different times (CASSANDRA-9124)
 + * Fix deleting from an empty list (CASSANDRA-9198)
 + * Update tuple and collection types that use a user-defined type when that UDT
 +   is modified (CASSANDRA-9148, CASSANDRA-9192)
 + * Use higher timeout for prepair and snapshot in repair (CASSANDRA-9261)
 + * Fix anticompaction blocking ANTI_ENTROPY stage (CASSANDRA-9151)
 + * Repair waits for anticompaction to finish (CASSANDRA-9097)
 + * Fix streaming not holding ref when stream error (CASSANDRA-9295)
 + * Fix canonical view returning early opened SSTables (CASSANDRA-9396)
 +Merged from 2.0:
+  * Fix counting cache serialization in request metrics (CASSANDRA-9466)
   * (cqlsh) Add LOGIN command to switch users (CASSANDRA-7212)
   * Clone SliceQueryFilter in AbstractReadCommand implementations (CASSANDRA-8940)
   * Push correct protocol notification for DROP INDEX (CASSANDRA-9310)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/e0ea4fbe/src/java/org/apache/cassandra/service/CacheService.java
----------------------------------------------------------------------
diff --cc src/java/org/apache/cassandra/service/CacheService.java
index 48c0941,cf0db97..a43d6d5
--- a/src/java/org/apache/cassandra/service/CacheService.java
+++ b/src/java/org/apache/cassandra/service/CacheService.java
@@@ -460,22 -331,18 +460,22 @@@ public class CacheService implements Ca
          }
      }
  
 -    public class KeyCacheSerializer implements CacheSerializer<KeyCacheKey, RowIndexEntry>
 +    public static class KeyCacheSerializer implements CacheSerializer<KeyCacheKey, RowIndexEntry>
      {
 -        public void serialize(KeyCacheKey key, DataOutput out) throws IOException
 +        public void serialize(KeyCacheKey key, DataOutputPlus out) throws IOException
          {
-             RowIndexEntry entry = CacheService.instance.keyCache.get(key);
+             RowIndexEntry entry = CacheService.instance.keyCache.getInternal(key);
              if (entry == null)
                  return;
 +
 +            CFMetaData cfm = Schema.instance.getCFMetaData(key.cfId);
 +            if (cfm == null)
 +                return; // the table no longer exists.
 +
              ByteBufferUtil.writeWithLength(key.key, out);
 -            Descriptor desc = key.desc;
 -            out.writeInt(desc.generation);
 +            out.writeInt(key.desc.generation);
              out.writeBoolean(true);
 -            RowIndexEntry.serializer.serialize(entry, out);
 +            cfm.comparator.rowIndexEntrySerializer().serialize(entry, out);
          }
  
          public Future<Pair<KeyCacheKey, RowIndexEntry>> deserialize(DataInputStream input, ColumnFamilyStore cfs) throws IOException


[03/10] cassandra git commit: Fix counting cache serialization in request metrics patch by Sankalp Kohli; reviewed by jbellis for CASSANDRA-9466

Posted by jb...@apache.org.
Fix counting cache serialization in request metrics
patch by Sankalp Kohli; reviewed by jbellis for CASSANDRA-9466


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/04287d44
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/04287d44
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/04287d44

Branch: refs/heads/cassandra-2.2
Commit: 04287d440a00d5d13c948007cd01954b782da05a
Parents: 2beb66e
Author: Jonathan Ellis <jb...@apache.org>
Authored: Tue May 26 13:13:38 2015 -0500
Committer: Jonathan Ellis <jb...@apache.org>
Committed: Tue May 26 13:13:38 2015 -0500

----------------------------------------------------------------------
 CHANGES.txt                                             | 1 +
 src/java/org/apache/cassandra/service/CacheService.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/04287d44/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index cf124b4..0bff87b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.0.16:
+ * Fix counting cache serialization in request metrics (CASSANDRA-9466)
  * (cqlsh) Add LOGIN command to switch users (CASSANDRA-7212)
  * Clone SliceQueryFilter in AbstractReadCommand implementations (CASSANDRA-8940)
  * Push correct protocol notification for DROP INDEX (CASSANDRA-9310)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/04287d44/src/java/org/apache/cassandra/service/CacheService.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/service/CacheService.java b/src/java/org/apache/cassandra/service/CacheService.java
index f626e17..cf0db97 100644
--- a/src/java/org/apache/cassandra/service/CacheService.java
+++ b/src/java/org/apache/cassandra/service/CacheService.java
@@ -335,7 +335,7 @@ public class CacheService implements CacheServiceMBean
     {
         public void serialize(KeyCacheKey key, DataOutput out) throws IOException
         {
-            RowIndexEntry entry = CacheService.instance.keyCache.get(key);
+            RowIndexEntry entry = CacheService.instance.keyCache.getInternal(key);
             if (entry == null)
                 return;
             ByteBufferUtil.writeWithLength(key.key, out);