[jira] [Commented] (AVRO-3601) C++ API header contains breaking include

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578314#comment-17578314 ] 

ASF subversion and git services commented on AVRO-3601:
-------------------------------------------------------

Commit 56eea3331a3aedb4a5889faf8799b6a5f36af9e8 in avro's branch refs/heads/avro-3601-c++-api-include from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=56eea3331 ]

AVRO-3601: C++ API header contains breaking include

Move impl/json/JsonDom.hh to api/json/

https://github.com/apache/avro/blob/ce2439d7a7669a5c7f2fa555c661770fbe67493a/lang/c%2B%2B/CMakeLists.txt#L97
includes the 'api/' folder, CMAKE_CURRENT_BINARY_DIR and Boost's
include dirs

Signed-off-by: Martin Tzvetanov Grigorov <mg...@apache.org>


> C++ API header contains breaking include
> ----------------------------------------
>
>                 Key: AVRO-3601
>                 URL: https://issues.apache.org/jira/browse/AVRO-3601
>             Project: Apache Avro
>          Issue Type: Bug
>            Reporter: Mike Ruffing
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Major
>
> Problem file/line: https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)