[GitHub] [hadoop] elek opened a new pull request #1584: HDDS-2237. KeyDeletingService throws NPE if it's started too early

[GitBox <gi...@apache.org>]

elek opened a new pull request #1584: HDDS-2237. KeyDeletingService throws NPE if it's started too early
URL: https://github.com/apache/hadoop/pull/1584
 
 
   1. OzoneManager starts KeyManager
   
   2. KeyManager starts KeyDeletingService
   
   3. KeyDeletingService uses OzoneManager.isLeader()
   
   4. OzoneManager.isLeader() uses omRatisServer
   
   5. omRatisServer can be null (bumm)
   
    
   
   Now the initialization order in OzoneManager:
   
    
   
   new KeymanagerServer() *Includes start()!!!!*
   
   omRatisServer initialization
   
   start() (includes KeyManager.start())
   
    
   
   The solution seems to be easy: start the key manager only from the OzoneManager.start() and not from the OzoneManager.instantiateServices()
   
   See: https://issues.apache.org/jira/browse/HDDS-2237

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org