You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/02/27 13:00:55 UTC

[GitHub] mdeuser commented on a change in pull request #176: Only fetch action code when saving or copying an action

mdeuser commented on a change in pull request #176: Only fetch action code when saving or copying an action
URL: https://github.com/apache/incubator-openwhisk-cli/pull/176#discussion_r170913245
 
 

 ##########
 File path: tests/src/test/scala/system/basic/WskActionTests.scala
 ##########
 @@ -230,8 +230,6 @@ abstract class WskActionTests extends TestHelpers with WskTestHelpers with JsHel
     assetHelper.withCleaner(wsk.action, name) { (action, _) =>
       action.create(name, Some(TestCLIUtils.getTestActionFilename("empty.js")))
     }
-    val rr = wsk.action.get(name)
-    wsk.parseJsonString(rr.stdout).getFieldPath("exec", "code") shouldBe Some(JsString(""))
 
 Review comment:
   in theory, these base tests are common between the cli and REST test contexts.  removing these two lines seems to cause a test coverage discrepancy.  curious.. why are these two lines being removed in this repo, but not in the incubator-openwhisk repo?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services