You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/04 05:08:24 UTC
[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1425: chore: Add upstream and service PATCH method unit test
Jaycean opened a new pull request #1425:
URL: https://github.com/apache/apisix-dashboard/pull/1425
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
#1332
___
- Add upstream and service unit test: using path parameter in PATCH update method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean closed pull request #1425: chore: Add upstream and service PATCH method unit test
Posted by GitBox <gi...@apache.org>.
Jaycean closed pull request #1425:
URL: https://github.com/apache/apisix-dashboard/pull/1425
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean closed pull request #1425: chore: Add upstream and service PATCH method unit test
Posted by GitBox <gi...@apache.org>.
Jaycean closed pull request #1425:
URL: https://github.com/apache/apisix-dashboard/pull/1425
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1425: chore: Add upstream and service PATCH method unit test
Posted by GitBox <gi...@apache.org>.
Jaycean commented on pull request #1425:
URL: https://github.com/apache/apisix-dashboard/pull/1425#issuecomment-773110524
PR #1169: remove the etcd dependency in the service unit test, so this PR is closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1425: chore: Add upstream and service PATCH method unit test
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1425:
URL: https://github.com/apache/apisix-dashboard/pull/1425#issuecomment-773047236
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1425?src=pr&el=h1) Report
> Merging [#1425](https://codecov.io/gh/apache/apisix-dashboard/pull/1425?src=pr&el=desc) (6c6d2d7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0a0a42ae1c81f21a03c98a991b707dba6b724364?el=desc) (0a0a42a) will **decrease** coverage by `9.53%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1425?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
- Coverage 66.59% 57.06% -9.54%
==========================================
Files 44 44
Lines 2937 2937
==========================================
- Hits 1956 1676 -280
- Misses 744 993 +249
- Partials 237 268 +31
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1425?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1425/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1425/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `45.23% <0.00%> (-52.39%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1425/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `35.18% <0.00%> (-51.86%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1425/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1425/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `44.11% <0.00%> (-32.36%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1425/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.18% <0.00%> (-27.88%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1425/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `64.51% <0.00%> (-19.36%)` | :arrow_down: |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1425/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `74.46% <0.00%> (-17.03%)` | :arrow_down: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1425/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `33.33% <0.00%> (-14.82%)` | :arrow_down: |
| [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1425/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `44.82% <0.00%> (-13.80%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1425/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1425?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1425?src=pr&el=footer). Last update [0a0a42a...6c6d2d7](https://codecov.io/gh/apache/apisix-dashboard/pull/1425?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1425: chore: Add upstream and service PATCH method unit test
Posted by GitBox <gi...@apache.org>.
Jaycean commented on pull request #1425:
URL: https://github.com/apache/apisix-dashboard/pull/1425#issuecomment-773110524
PR #1169: remove the etcd dependency in the service unit test, so this PR is closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org