You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2025/07/11 18:49:14 UTC
[PR] Implement HuffmanCodec with LiteSpeed [trafficserver]
bneradt opened a new pull request, #12357:
URL: https://github.com/apache/trafficserver/pull/12357
Performance tooling highlights hpack decoding as an expensive operation for us. This improves hpack performance by using the MIT licensed LiteSpeed implementation.
When testing this in production, it seems to address the huffman_decode performance hot spot. It no longer appears near the top in `perf top`.
Fixes: #12321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement HuffmanCodec with LiteSpeed [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #12357:
URL: https://github.com/apache/trafficserver/pull/12357#issuecomment-3089858964
> Looks like it's a simple replacement. I don't have any concerns on the changes.
>
> Could you note the version number or commit id of the borrowed code somewhere? Since their code is still updated sometimes, we probably need the information to see if we have important changes on our copy.
Good idea. I added a README.md to the lib/ls-hpack directory that gives some history of our use of LiteSpeed and references the version we've borrowed from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement HuffmanCodec with LiteSpeed [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #12357:
URL: https://github.com/apache/trafficserver/pull/12357#issuecomment-3090286811
[approve ci autest 2]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement HuffmanCodec with LiteSpeed [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #12357:
URL: https://github.com/apache/trafficserver/pull/12357#issuecomment-3066095455
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement HuffmanCodec with LiteSpeed [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #12357:
URL: https://github.com/apache/trafficserver/pull/12357#issuecomment-3090615503
[approval ci autest 2]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement HuffmanCodec with LiteSpeed [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #12357:
URL: https://github.com/apache/trafficserver/pull/12357#issuecomment-3090617246
[approve ci autest 2]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement HuffmanCodec with LiteSpeed [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #12357:
URL: https://github.com/apache/trafficserver/pull/12357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org