You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/06/26 14:05:05 UTC
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9606: fs/rpmsgfs: Zero dirs after realloc to avoid stale data
xiaoxiang781216 commented on code in PR #9606:
URL: https://github.com/apache/nuttx/pull/9606#discussion_r1242259649
##########
fs/rpmsgfs/rpmsgfs_server.c:
##########
@@ -285,6 +285,9 @@ static int rpmsgfs_attach_dir(FAR struct rpmsgfs_server_s *priv,
return -ENOMEM;
}
+ memset(&tmp[priv->dir_nums], 0, sizeof(FAR void *) *
Review Comment:
no, the code wants to zero the array of void *, not the buffer point by void *.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org