[GitHub] [spark] mridulm commented on pull request #37779: [wip][SPARK-40320][Core] Executor should exit when it failed to initialize for fatal error

[GitBox <gi...@apache.org>]

mridulm commented on PR #37779:
URL: https://github.com/apache/spark/pull/37779#issuecomment-1254457075

   I am not sure I follow what the code snippet is trying to do.
   Changing the code to :
   
   ```
     private def receiveLoop() {
         Executors.newSingleThreadExecutor(threadFactory).execute(new MessageLoop)
       }
   ```
   does cause the `uncaughtException` to be invoked - as expected.
   If we catch the `Throwable` in `receiveLoop` before that, then obviously it is no longer an uncaught exception - and so `MyExceptionHandler.uncaughtException` wont be invoked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org